Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-47935

Autosave message covers text you are editing

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Setup

      1. Set the autosave frequency (autosavefrequency) to something low i.e. 5 seconds.

      Saving text

      1. Load a page that has an atto editor on it (i.e. profile settings page) and begin entering text. Wait 5 seconds for the entered text to auto-save
      2. Observe the notification that appears. Make sure it looks appropriately sized and doesn't interfere with anything else.
      3. Repeat the same test but for a page with many editors, i.e. the edit quiz question page for a multiple choice question.

      Loading drafts

      1. After performing the previous set of tests, reload your page and ensure that drafts are loaded correctly and that the notification behaves appropriately.

      Pages with autosave disabled

      1. As a student completing a quiz question with an atto editor (i.e. essay question), ensure that the editor_atto_wrapper class is not inserted into any div in the DOM. This is intentional as these quiz has it's own autosave and we shouldn't be inserting padding in these editors.

      Error cases

      1. Enter some text into an editor and make sure a draft saves fine. Verify this by finding it in the mdl_editor_atto_autosave table (SELECT * FROM mdl_editor_atto_autosave).
      2. Cause an error condition to occur. We can do this by changing the mdl_editor_atto_autosave table to a different name (ALTER TABLE mdl_editor_atto_autosave RENAME TO mdl_asdasdasf).
      3. Reload the page. You should observe an error notification on the editor.
      4. Don't forget to change the table name back.

      LTR/RTL

      1. Ensure that everything behaves as expected in both right-to-left and left-to-right languages.
      Show
      Setup Set the autosave frequency (autosavefrequency) to something low i.e. 5 seconds. Saving text Load a page that has an atto editor on it (i.e. profile settings page) and begin entering text. Wait 5 seconds for the entered text to auto-save Observe the notification that appears. Make sure it looks appropriately sized and doesn't interfere with anything else. Repeat the same test but for a page with many editors, i.e. the edit quiz question page for a multiple choice question. Loading drafts After performing the previous set of tests, reload your page and ensure that drafts are loaded correctly and that the notification behaves appropriately. Pages with autosave disabled As a student completing a quiz question with an atto editor (i.e. essay question), ensure that the editor_atto_wrapper class is not inserted into any div in the DOM. This is intentional as these quiz has it's own autosave and we shouldn't be inserting padding in these editors. Error cases Enter some text into an editor and make sure a draft saves fine. Verify this by finding it in the mdl_editor_atto_autosave table (SELECT * FROM mdl_editor_atto_autosave). Cause an error condition to occur. We can do this by changing the mdl_editor_atto_autosave table to a different name (ALTER TABLE mdl_editor_atto_autosave RENAME TO mdl_asdasdasf). Reload the page. You should observe an error notification on the editor. Don't forget to change the table name back. LTR/RTL Ensure that everything behaves as expected in both right-to-left and left-to-right languages.
    • Affected Branches:
      MOODLE_28_STABLE
    • Fixed Branches:
      MOODLE_28_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-47935-master
    • Sprint:
      FRONTEND Sprint 16, Team A Sprint 1
    • Issue size:
      Medium

      Description

      Damo will love this.

      In writing my first long post on moodle.org. I realised that when writing a long piece of text in the atto editor (the exact use case where the draft-saved comes in useful) the autosave placement is exactly the wrong place - i.e. where you likely to be typing the whole time. You can click to dismiss it but that gets annoying.

      Maybe it would be better placed elsewhere.

      Steps to reproduce:

      1. In admin settings Change atto autosave frequency to 5 seconds
      2. Enter some long amount of text in editor (e.g. copy from http://beeripsum.com)
      3. Start trying to write an essay about your love or dislike of beer

      Note that the line you are editing/typing will be obscured constantly and it makes it harder to write the message.

        Attachments

          Activity

            People

            • Votes:
              6 Vote for this issue
              Watchers:
              10 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                2/Feb/15