Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-47957

Atto misbehaves on grading page, applies formatting to wrong element

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Duplicate
    • Affects Version/s: 2.7.2
    • Fix Version/s: None
    • Component/s: HTML Editor (Atto), Quiz
    • Labels:
    • Testing Instructions:
      Hide

      Here's how to reproduce:

      1. Create a quiz.
      2. Add an essay question.
      3. Attempt the quiz as a student
      4. add some text to the essay question.
      5. Select a word, click on the button to make it bold.
      6. Double-click on a different word, click on the button to add italics
      7. *Verify* the word that is now selected becomes italics, not the bold word.
      8. Double-click in the middle of a word in bold.
      9. *Verify* the bold button is depressed (active).
      10. Double-click in the middle of the word in italic.
      11. *Verify* the italic button is depressed (active).
      12. Submit all and finish.
      13. Go to Quiz administration -> Results -> Grades
      14. Click the score for a question (acually it will probably say 'Requires grading') to open a review of that question in a pop-up.
      15. Click on "Make comment or override mark" to grade the question
      16. Go to the comment field and add some text.
      17. Select a word, click on the button to make it bold.
      18. Double-click on a different word, click on the button to add italics
      19. *Verify* the word that is now selected becomes italics, not the bold word.
      20. Double-click in the middle of a word in bold.
      21. *Verify* the bold button is depressed (active).
      22. Double-click in the middle of the word in italic.
      Show
      Here's how to reproduce: Create a quiz. Add an essay question. Attempt the quiz as a student add some text to the essay question. Select a word, click on the button to make it bold. Double-click on a different word, click on the button to add italics * Verify * the word that is now selected becomes italics, not the bold word. Double-click in the middle of a word in bold. * Verify * the bold button is depressed (active). Double-click in the middle of the word in italic. * Verify * the italic button is depressed (active). Submit all and finish. Go to Quiz administration -> Results -> Grades Click the score for a question (acually it will probably say 'Requires grading') to open a review of that question in a pop-up. Click on "Make comment or override mark" to grade the question Go to the comment field and add some text. Select a word, click on the button to make it bold. Double-click on a different word, click on the button to add italics * Verify * the word that is now selected becomes italics, not the bold word. Double-click in the middle of a word in bold. * Verify * the bold button is depressed (active). Double-click in the middle of the word in italic.
    • Affected Branches:
      MOODLE_27_STABLE
    • Pull Master Branch:
      MDL-47957-master

      Description

      This is a weird one, easier to see than to describe.

      Atto works fine everywhere I can see on a local site (2.7 weekly), but when teachers go to a quiz grading page (/mod/quiz/comment.php?attempt=260&slot=1), the buttons/formatting does not get applied to the right part of the text.

      Here's how to reproduce:

      • create a quiz, create a question (any type), submit some answer
      • go to the gradebook page, click to mark the attempt, then click on "Make comment or override mark" to grade the question
      • go to the comment section, add some text
      • select a word, click on the button to make it bold
      • double-click on a different work, click on the button to add italics
      • result : the previously selected word is now in italics
      • expected : the currently selected word should be in italics.

      EDIT: coworker that found the issue tells me this also happens when student submits an answer.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              timhunt Tim Hunt
              Reporter:
              scyrma Mathieu Petit-Clair
              Peer reviewer:
              Tim Hunt Tim Hunt
              Participants:
              Component watchers:
              Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Tim Hunt, Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              1 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: