Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-47963

New quiz editing UI lets you edit things after there are attempts

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.8
    • Fix Version/s: 2.8
    • Component/s: Quiz
    • Labels:
    • Testing Instructions:
      Hide
      1. In one browser, log in as teacher.
      2. Create a new quiz.
      3. Add some questions.
      4. Leave that browser open.
      5. In another browser, log in as student.
      6. Start an attempt at the quiz.
      7. Back in the teacher's browser, try these actions:
        • click an add/remove page break icon
        • click an x delete icon.
        • drag a question to move it.
        • use the repaginate button at the top.
      8. In each case verify that you get an error preventing you from doing that.
      Show
      In one browser, log in as teacher. Create a new quiz. Add some questions. Leave that browser open. In another browser, log in as student. Start an attempt at the quiz. Back in the teacher's browser, try these actions: click an add/remove page break icon click an x delete icon. drag a question to move it. use the repaginate button at the top. In each case verify that you get an error preventing you from doing that.
    • Affected Branches:
      MOODLE_28_STABLE
    • Fixed Branches:
      MOODLE_28_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      Steps to reproduce:

      1. In one browser, log in as teacher.
      2. Create a new quiz.
      3. Add some questions.
      4. Leave that browser open.
      5. In another browser, log in as student.
      6. Start an attempt at the quiz.
      7. Back in the teacher's browser, try to repaginate the quiz, or delete a question.

      Expected result: You should get an error since you cannot edit a quiz that has been attempted.

      Actual result: The edit work!

      Once you have reloaded the edit page, the restrictions are enforced.

      The problem is that the Ajax scripts repaginate.php and edit_rest.php do not check the 'no attempts' condition.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              timhunt Tim Hunt
              Reporter:
              timhunt Tim Hunt
              Peer reviewer:
              Damyon Wiese
              Integrator:
              Dan Poltawski
              Tester:
              Simey Lameze
              Participants:
              Component watchers:
              Tim Hunt, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                10/Nov/14