[MDL-47963] New quiz editing UI lets you edit things after there are attempts - Moodle Tracker

XML

Word

Printable

Affected Branches:
MOODLE_28_STABLE
Fixed Branches:
MOODLE_28_STABLE
Pull from Repository:
git://github.com/timhunt/moodle.git
Pull Master Branch:
~~MDL-47963~~
Pull Master Diff URL:
https://github.com/timhunt/moodle/compare/master...MDL-47963
Testing Instructions:
Hide

In one browser, log in as teacher.

Create a new quiz.

Add some questions.

Leave that browser open.

In another browser, log in as student.

Start an attempt at the quiz.

Back in the teacher's browser, try these actions:

click an add/remove page break icon

click an x delete icon.

drag a question to move it.

use the repaginate button at the top.

In each case verify that you get an error preventing you from doing that.
Show
In one browser, log in as teacher. Create a new quiz. Add some questions. Leave that browser open. In another browser, log in as student. Start an attempt at the quiz. Back in the teacher's browser, try these actions: click an add/remove page break icon click an x delete icon. drag a question to move it. use the repaginate button at the top. In each case verify that you get an error preventing you from doing that.

Steps to reproduce:

In one browser, log in as teacher.
Create a new quiz.
Add some questions.
Leave that browser open.
In another browser, log in as student.
Start an attempt at the quiz.
Back in the teacher's browser, try to repaginate the quiz, or delete a question.

Expected result: You should get an error since you cannot edit a quiz that has been attempted.

Actual result: The edit work!

Once you have reloaded the edit page, the restrictions are enforced.

The problem is that the Ajax scripts repaginate.php and edit_rest.php do not check the 'no attempts' condition.

blocks

MDLQA-7381 CLONE - A teacher can add multiple questions to a quiz and re-paginate a quiz

caused a regression

MDL-48168 It should be possible to edit the overall max grade after a quiz has been attempted

Participants:: CiBoT, Damyon Wiese, Dan Poltawski, Eloy Lafuente (stronk7), Simey Lameze, Tim Hunt

Component watchers:: Tim Hunt, Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie