Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-47980

Accessibility of Single view: Missing labels

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.8
    • Fix Version/s: 2.8
    • Component/s: Gradebook
    • Labels:
    • Testing Instructions:
      Hide

      Visual inspection

      1. On a test course (size S should be fine), go to the single view (course administration -> grades -> single view).
        • Note that the select boxes for selecting an assignment or student now have labels.
      2. Select an assignment.
      3. On the assignment page, mouse hover the override all / none and excldue all / none links.
        • Verify that there are title attributes on the links and that they pop up on hover.
      4. Scroll down to the bottom of the page to the bulk insert controls.
        • Note that both fields now have labels (check the for attribute on each).
        • Note that the fields now live within a fieldset with a legend for a screenreader to use.

      Manual testing

      1. On a test course, go to the single view for an assignment.
      2. Scroll down to the bottom of the page to the bulk insert controls.
      3. Check the box marked Perform bulk insert, and set the controls to insert the value 13.0 for All grades, then click Update.
        • Verify that grades are updated as you'd expect, i.e. that all participants for the assignment you selected now have a grade of 13.0.
      4. Go to the single view for a given participant.
        • Observe that the participant has one overridden grade of 13.0 for the previously-selected assignment.
      5. Scroll down to the bottom of the page to the bulk insert controls.
      6. Check the box marked Perform bulk insert, and set the controls to insert the value 27.0 for Empty grades, then click Update.
        • Verify that the participant has a grade of 13.0 for one activity, and 27.0 for all others.

      Behat testing
      Run tests with the tag @gradereport_singleview.

      Show
      Visual inspection On a test course (size S should be fine), go to the single view (course administration -> grades -> single view). Note that the select boxes for selecting an assignment or student now have labels. Select an assignment. On the assignment page, mouse hover the override all / none and excldue all / none links. Verify that there are title attributes on the links and that they pop up on hover. Scroll down to the bottom of the page to the bulk insert controls. Note that both fields now have labels (check the for attribute on each). Note that the fields now live within a fieldset with a legend for a screenreader to use. Manual testing On a test course, go to the single view for an assignment. Scroll down to the bottom of the page to the bulk insert controls. Check the box marked Perform bulk insert , and set the controls to insert the value 13.0 for All grades , then click Update . Verify that grades are updated as you'd expect, i.e. that all participants for the assignment you selected now have a grade of 13.0. Go to the single view for a given participant. Observe that the participant has one overridden grade of 13.0 for the previously-selected assignment. Scroll down to the bottom of the page to the bulk insert controls. Check the box marked Perform bulk insert , and set the controls to insert the value 27.0 for Empty grades , then click Update . Verify that the participant has a grade of 13.0 for one activity, and 27.0 for all others. Behat testing Run tests with the tag @gradereport_singleview .
    • Affected Branches:
      MOODLE_28_STABLE
    • Fixed Branches:
      MOODLE_28_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-47980-master

      Description

      This issue fixes the following issues on the single view:

      • missing label elements for the two select boxes for users and grades
      • missing fieldset wrapper with legend for the bulk insert fields
      • missing label element for one of the bulk insert fields
      • missing title attributes for override and exclude all / none links

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  10/Nov/14