Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-47993

Import from Microsoft calendar file issue

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Manual instructions:

      Steps:
      1. go to Calendar, Click Manage subscriptions.
      2. Under Import Calendar, Fill in name, Set import from to calendar file, Choose file(/lib/tests/fixtures/ms_outlook_2010.ics), Type of event is site event.
      3. Click add.
      4. Result without the patch: zero import, created page.
      5. Result with the patch: 1 import, 1 created page.

      Phpunit test instructions:
      1. prepare the system for phpunit testing
      2. run command line with:
      vendor/bin/phpunit --filter core_calendar_ical_testcase::test_calendar_add_subscription

      Show
      Manual instructions: Steps: 1. go to Calendar, Click Manage subscriptions. 2. Under Import Calendar, Fill in name, Set import from to calendar file, Choose file(/lib/tests/fixtures/ms_outlook_2010.ics), Type of event is site event. 3. Click add. 4. Result without the patch: zero import, created page. 5. Result with the patch: 1 import, 1 created page. Phpunit test instructions: 1. prepare the system for phpunit testing 2. run command line with: vendor/bin/phpunit --filter core_calendar_ical_testcase::test_calendar_add_subscription
    • Affected Branches:
      MOODLE_25_STABLE, MOODLE_27_STABLE
    • Fixed Branches:
      MOODLE_27_STABLE, MOODLE_28_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      master_MDL-47993

      Description

      Our client sent us an Microsoft Outlook 2010 ical file which he is unable to upload to the Calendar. We found several issues in the bennu library:

      • DTEND;TZID and DTSTAR;TZID does not support quotations
      • X-ALT-DESC does not support FMTTYPE property
      • wrong validation for mimetype parameters of FMTTYPE property

      We propose a patch to fix the above issues and added the unit tests.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              oleg Oleg Demeshev
              Reporter:
              oleg Oleg Demeshev
              Peer reviewer:
              Petr Skoda
              Integrator:
              Sam Hemelryk
              Tester:
              Frédéric Massart
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              1 Vote for this issue
              Watchers:
              7 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                12/Jan/15