Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-48002

Strip quoted text from "reply by email" posts

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.8, 2.8.5
    • Fix Version/s: 2.8.6
    • Component/s: Forum
    • Testing Instructions:
      Hide

      Testing Difficulty
      Extremly difficult

      Prerequisite

      1. You need to be able to send and recieve emails
      2. You need reply by email setup for forums with atleast 5 clients - Gmail, Yahoo, outlook, thunderbird, evolution
      3. You need to test the test in three different modes of your client - html only, text only, html and text both (so 5 * 3 * 2 branches = 30 tests)
      4. Some clients might not support all modes, the mode settings are generally located under preferences tab.

      Setup

      1. A forum with a thread and two teachers A and B
      2. Both A and B are subscribed to the thread.

      Test

      1. Make a post as A selecting "Mail now" while posting
      2. Run cron
      3. Check B's email there should be one.
      4. Make sure the email contains text like "You can reply to this forum post via email" at bottom
      5. Reply to that email as B
      6. Run cron
      7. Make sure your response got posted in the forum thread.
      8. Make sure it doesn't contain any quoted text like "A wrote ... - a copy of A's initial post"
      Show
      Testing Difficulty Extremly difficult Prerequisite You need to be able to send and recieve emails You need reply by email setup for forums with atleast 5 clients - Gmail, Yahoo, outlook, thunderbird, evolution You need to test the test in three different modes of your client - html only, text only, html and text both (so 5 * 3 * 2 branches = 30 tests) Some clients might not support all modes, the mode settings are generally located under preferences tab. Setup A forum with a thread and two teachers A and B Both A and B are subscribed to the thread. Test Make a post as A selecting "Mail now" while posting Run cron Check B's email there should be one. Make sure the email contains text like "You can reply to this forum post via email" at bottom Reply to that email as B Run cron Make sure your response got posted in the forum thread. Make sure it doesn't contain any quoted text like "A wrote ... - a copy of A's initial post"
    • Difficulty:
      Difficult
    • Affected Branches:
      MOODLE_28_STABLE
    • Fixed Branches:
      MOODLE_28_STABLE
    • Pull Master Branch:
      MDL-48002-master
    • Sprint:
      Team Beards Sprint 6

      Description

      I don't think its acceptable to have the body of all the content posted as part of the forum post, it makes the forums unusuable.

      Maybe we should use the helpdesk software example of a 'reply above this line' to reduce that rubbish.

      Another related issue in my particular example in the screenshot, you can see that you also embed the reply-to link there - this is a security issue because if I know the email address of the poster (i.e. look in their user profile for a lot of moodle.org users) and that special email address I can use it to generate more posts from the user- and its displayed right there in the forum. We should keep that special address private as possible.

        Attachments

        1. jira-capture-screenshot-20150428-164700-811.png
          41 kB
          John Okely
        2. reply_to_email.png
          272 kB
          Dan Poltawski
        3. tokenemail.png
          80 kB
          Ankit Agarwal

          Issue Links

            Activity

              People

              • Votes:
                5 Vote for this issue
                Watchers:
                12 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  11/May/15