Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-48015

Gradebook - columns become misaligned by a category with no total and items

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      PHPUnit
      1. Run core_grade_testsuite.
        • Confirm that there are no errors or failures.
      Manual testing
      1. Restore the attached course backups MDL-48015-test-course.mbz and GloriousGradebook.mbz.
      2. Go to the course restored from MDL-48015-test-course.mbz.
      3. Under Course administration, Gradebook setup.
        • Confirm that there are no misaligned rows on the Gradebook setup table.
      4. Under Course administration, click Grades.
        • Confirm that there are no extra/misaligned column headers.
      5. Repeat the above testing instructions for the course restored from GloriousGradebook.mbz.

      Bonus

      1. Create any other combination of grade category/item combinations that you can think of and confirm that there are no extra/misaligned column headers.
      Show
      PHPUnit Run core_grade_testsuite. Confirm that there are no errors or failures. Manual testing Restore the attached course backups MDL-48015-test-course.mbz and GloriousGradebook.mbz . Go to the course restored from MDL-48015-test-course.mbz . Under Course administration, Gradebook setup. Confirm that there are no misaligned rows on the Gradebook setup table. Under Course administration, click Grades. Confirm that there are no extra/misaligned column headers. Repeat the above testing instructions for the course restored from GloriousGradebook.mbz . Bonus Create any other combination of grade category/item combinations that you can think of and confirm that there are no extra/misaligned column headers.
    • Affected Branches:
      MOODLE_27_STABLE, MOODLE_29_STABLE, MOODLE_30_STABLE, MOODLE_31_STABLE
    • Fixed Branches:
      MOODLE_29_STABLE, MOODLE_30_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-48015-master
    • Pull Master Diff URL:
    • Sprint:
      3.1 Sprint 4
    • Issue size:
      Small

      Description

      When a category exists that has no total and no grade items within it, it creates a column in the header of the gradebook, but no column below it. The columns of grades gets shifted to fill the space below that category, therefore the headings of grade items are shown above the wrong items.

      To reproduce:

      1. Go to Gradebook
      2. Create a category with Category Total - Grade Type = None
      3. Make sure category is before other categories with grade items
      4. In Grade Report view:
        1. there should be a blank column beneath empty category header to keep grade items aligned
        2. grade items for next category incorrectly show beneath empty category header

        Attachments

        1. category_total_setting.png
          category_total_setting.png
          21 kB
        2. columnsaligned.png
          columnsaligned.png
          36 kB
        3. columnsmisaligned.png
          columnsmisaligned.png
          35 kB
        4. GloriousGradebook.mbz
          191 kB
        5. graderreport.png
          graderreport.png
          48 kB
        6. MDL-48015-test-course.mbz
          757 kB
        7. setup_screen.png
          setup_screen.png
          52 kB

          Issue Links

          is duplicated by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-52671 Categories with grade type set to "None" render a header cell, but no table cells, causing all other columns in the Grader report to shift to the left

          • Minor - Minor loss of function where workaround is possible
          • Closed

            Activity

              People

              Assignee:
              jpataleta Jun Pataleta
              Reporter:
              john-i John Iglar
              Peer reviewer:
              Andrew Nicols
              Integrator:
              David Monllaó
              Tester:
              Damyon Wiese
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
              Votes:
              7 Vote for this issue
              Watchers:
              17 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                14/Mar/16