Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-48050

Existing scripts detecting https see a change in results

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.8
    • Fix Version/s: 2.8
    • Component/s: Authentication
    • Labels:

      Description

      E.g. Auth CAS SSL detection problem

      This is a regression from MDL-28484.

      auth cas has it's own custom _isHttps function which checks
      $_SERVER['HTTP_X_FORWARDED_PROTO']
      $_SERVER['HTTPS']
      $_SERVER['SERVER_PORT']
      $_SERVER['HTTP_X_FORWARDED_PORT']

      I'm not worried about updating auth_cas to use the new function, I am worried that adding the function caused a regression in existing scripts (and hence all third party scripts).

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  10/Nov/14