Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-48050

Existing scripts detecting https see a change in results

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 2.8
    • 2.8
    • Authentication

    Description

      E.g. Auth CAS SSL detection problem

      This is a regression from MDL-28484.

      auth cas has it's own custom _isHttps function which checks
      $_SERVER['HTTP_X_FORWARDED_PROTO']
      $_SERVER['HTTPS']
      $_SERVER['SERVER_PORT']
      $_SERVER['HTTP_X_FORWARDED_PORT']

      I'm not worried about updating auth_cas to use the new function, I am worried that adding the function caused a regression in existing scripts (and hence all third party scripts).

      Attachments

        Issue Links

          Activity

            People

              damyon Damyon Wiese
              damyon Damyon Wiese
              Dan Poltawski Dan Poltawski
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Frédéric Massart Frédéric Massart
              David Woloszyn, Huong Nguyen, Jake Dallimore, Michael Hawkins, Stevani Andolo
              Votes:
              1 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                10/Nov/14