Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-48148

Forum reply handler subject gets recursive

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 2.8
    • Fix Version/s: 2.8.2
    • Component/s: Forum
    • Labels:
    • Testing Instructions:
      Hide

      The following instructions assume that message_inbound is set up and working for mod_forum replies

      1. Create a new forum in a course
      2. Create a discussion in that forum
      3. Set $CFG->maxeditingtime = -1;
      4. Run the forum task:

        php admin/tool/task/cli/schedule_task.php --execute='\mod_forum\task\cron_task'
        

      5. Reply to the e-mail with the standard reply header for your mail client - this will include both the post subject, and the course name
      6. Run the pickup task:

        php admin/tool/task/cli/schedule_task.php --execute='\tool_messageinbound\task\pickup_task'
        

        • Confirm that the message was posted
      7. View the discussion in Moodle
        • *Confirm that the subject was changed to the standard "Re: [original post subject]"
      8. Reply to the e-mail again, this time change the subject different and send the message
      9. Run the pickup task:

        php admin/tool/task/cli/schedule_task.php --execute='\tool_messageinbound\task\pickup_task'
        

        • Confirm that the message was posted
      10. View the discussion in Moodle
        • *Confirm that the subject was the subject that you specified"
      11. In the forum, manually add a reply. Specify a new subject which does not include the original post subject, or the "Re" string.
      12. Run the forum task:

        php admin/tool/task/cli/schedule_task.php --execute='\mod_forum\task\cron_task'
        

      13. Reply to the e-mail with the standard reply header for your mail client - this will include both the post subject, and the course name
      14. Run the pickup task:

        php admin/tool/task/cli/schedule_task.php --execute='\tool_messageinbound\task\pickup_task'
        

        • Confirm that the message was posted
      15. View the discussion in Moodle
        • *Confirm that the subject was changed to the standard "Re: [original post subject]"
      16. In the forum, manually add a reply. Specify a new subject which does not include the original post subject but does include the "re: ' string.
      17. Run the forum task:

        php admin/tool/task/cli/schedule_task.php --execute='\mod_forum\task\cron_task'
        

      18. Reply to the e-mail with the standard reply header for your mail client - this will include both the post subject, and the course name
      19. Run the pickup task:

        php admin/tool/task/cli/schedule_task.php --execute='\tool_messageinbound\task\pickup_task'
        

        • Confirm that the message was posted
      20. View the discussion in Moodle
        • *Confirm that the subject was changed to the standard "Re: [original post subject]"
      Show
      The following instructions assume that message_inbound is set up and working for mod_forum replies Create a new forum in a course Create a discussion in that forum Set $CFG->maxeditingtime = -1; Run the forum task: php admin/tool/task/cli/schedule_task.php --execute='\mod_forum\task\cron_task' Reply to the e-mail with the standard reply header for your mail client - this will include both the post subject, and the course name Run the pickup task: php admin/tool/task/cli/schedule_task.php --execute='\tool_messageinbound\task\pickup_task' Confirm that the message was posted View the discussion in Moodle *Confirm that the subject was changed to the standard "Re: [original post subject] " Reply to the e-mail again, this time change the subject different and send the message Run the pickup task: php admin/tool/task/cli/schedule_task.php --execute='\tool_messageinbound\task\pickup_task' Confirm that the message was posted View the discussion in Moodle *Confirm that the subject was the subject that you specified" In the forum, manually add a reply. Specify a new subject which does not include the original post subject, or the "Re" string. Run the forum task: php admin/tool/task/cli/schedule_task.php --execute='\mod_forum\task\cron_task' Reply to the e-mail with the standard reply header for your mail client - this will include both the post subject, and the course name Run the pickup task: php admin/tool/task/cli/schedule_task.php --execute='\tool_messageinbound\task\pickup_task' Confirm that the message was posted View the discussion in Moodle *Confirm that the subject was changed to the standard "Re: [original post subject] " In the forum, manually add a reply. Specify a new subject which does not include the original post subject but does include the "re: ' string. Run the forum task: php admin/tool/task/cli/schedule_task.php --execute='\mod_forum\task\cron_task' Reply to the e-mail with the standard reply header for your mail client - this will include both the post subject, and the course name Run the pickup task: php admin/tool/task/cli/schedule_task.php --execute='\tool_messageinbound\task\pickup_task' Confirm that the message was posted View the discussion in Moodle *Confirm that the subject was changed to the standard "Re: [original post subject] "
    • Affected Branches:
      MOODLE_28_STABLE
    • Fixed Branches:
      MOODLE_28_STABLE
    • Pull Master Branch:
      MDL-48148-master
    • Sprint:
      FRONTEND Sprint 15

      Description

      It gets longer and longer because the course name is included in the subject.

      Need to match the discussion name, and if present replace with the standard reply subject.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              dobedobedoh Andrew Nicols
              Reporter:
              dobedobedoh Andrew Nicols
              Peer reviewer:
              Zachary Durber
              Integrator:
              Sam Hemelryk
              Tester:
              John Okely
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                12/Jan/15