Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-48160

Improve all block region layouts when coded for RTL

    Details

    • Testing Instructions:
      Hide
      1. Using Clean theme make sure that there are at least three blocks either side of the main content.
      2. Dock all LEFT blocks and verify that the main content expands to fill the empty side-pre block region. Un-dock the blocks.
      3. Dock all RIGHT blocks and verify that the main content expands to fill the empty side-post block region. Un-dock the blocks.
      4. Dock ALL blocks and verify that the main content expands to fill the empty side block regions.
      5. Undock the blocks and continue.
      6. Go to Site Administration > Notifications and verify the page is set out as it should be with blocks on the left. Dock the blocks and check as 2. above.
        PLEASE NOTE When testing in RTL it may be easier to understand the way the blocks work. So 'Pre' in this case mean 'before main content' and so in RTL will be on the right. Likewise 'Post' in this case means 'after main content' and so will be on the left. And so what is happening in the layout, is that the containers carrying the 'side pre' and 'side post' blocks, slide from side to side. There's no JavaScript trickery here!
      7. Change language to a RTL one like Hebrew or Arabic and test 1. to 4. again.
      8. Still in RTL mode TEST as 5. above but note that the blocks will be on the RIGHT this time. Dock the blocks and check as 3. above.
      Show
      Using Clean theme make sure that there are at least three blocks either side of the main content. Dock all LEFT blocks and verify that the main content expands to fill the empty side-pre block region. Un-dock the blocks. Dock all RIGHT blocks and verify that the main content expands to fill the empty side-post block region. Un-dock the blocks. Dock ALL blocks and verify that the main content expands to fill the empty side block regions. Undock the blocks and continue. Go to Site Administration > Notifications and verify the page is set out as it should be with blocks on the left. Dock the blocks and check as 2. above. PLEASE NOTE When testing in RTL it may be easier to understand the way the blocks work. So 'Pre' in this case mean 'before main content' and so in RTL will be on the right. Likewise 'Post' in this case means 'after main content' and so will be on the left. And so what is happening in the layout, is that the containers carrying the 'side pre' and 'side post' blocks, slide from side to side. There's no JavaScript trickery here! Change language to a RTL one like Hebrew or Arabic and test 1. to 4. again. Still in RTL mode TEST as 5. above but note that the blocks will be on the RIGHT this time. Dock the blocks and check as 3. above.
    • Affected Branches:
      MOODLE_28_STABLE
    • Fixed Branches:
      MOODLE_29_STABLE
    • Pull Master Branch:
      wip-MDL-48160_master

      Description

      If the layout in Bootstrapbase and Clean themes were coded differently so that the side blocks shift from left to the right and visa versa then there would be no need for the 'blockmanipulation' code because the layout itself would do the job, meaning that 'side-pre' can either be on the left in LTR mode and on the right in RTL mode, and that 'side-post' can be on the right in LTR mode and on the left in RTL mode. This would also mean that the current region configuration for "region-bs-main-and-pre" and "region-bs-main-and-post" would be obsolete.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  7 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    11/May/15