Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-48174

$CFG->skiplangupgrade is not respected by update_langpacks_task and should be allowed by behat whitelist

    XMLWordPrintable

    Details

    • Affected Branches:
      MOODLE_28_STABLE
    • Fixed Branches:
      MOODLE_28_STABLE
    • Pull Master Branch:
      wip-mdl-48174
    • Testing Instructions:
      Hide

      run behat with --name on master:

      1. Receiving notification on site level
      2. Award badge on course completion
      3. Receiving notification on course level

      These should fail until skiplangupgrade is defined in config.php

      Run php admin/tool/task/cli/schedule_task.php --execute=\\tool_langimport\\task
      update_langpacks_task
      with $CFG->skiplangupgrade set and not

      Show
      run behat with --name on master: Receiving notification on site level Award badge on course completion Receiving notification on course level These should fail until skiplangupgrade is defined in config.php Run php admin/tool/task/cli/schedule_task.php --execute=\\tool_langimport\\task update_langpacks_task with $CFG->skiplangupgrade set and not

      Description

      In lib/upgradelib.php - upgrade_language_pack(), $CFG->skiplangupgrade is checked before lang pack is updated, but in update_langpacks_task it is not respected.

      This is required to be respected while we are on on-sync period. As lang pack for master is not available during this time. Which fails behat on master.

        Attachments

          Activity

            People

            Assignee:
            rajeshtaneja Rajesh Taneja
            Reporter:
            rajeshtaneja Rajesh Taneja
            Peer reviewer:
            Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
            Integrator:
            Dan Poltawski Dan Poltawski
            Tester:
            Dan Poltawski Dan Poltawski
            Participants:
            Component watchers:
            Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, David Mudrák (@mudrd8mz), Helen Foster, Víctor Déniz Falcón
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              13/Nov/14