[MDL-48179] Backup progress: Can time out when compressing large backup - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 2.7.3
Fix Version/s: 2.7.4, 2.8.2
Component/s: Backup
Labels:
- ci
- patch
- triaged
- ui_change

Testing Instructions:

Hide

NOTE: It is not feasible to reproduce the actual problem (I can't supply the 16GB backup). These tests only confirm that the zip stage of the backup process is not broken.

1. In server settings, set 'enabletgzbackup' to off (default).
2. Go to any course and do a backup using default settings.
3. Restore the backup to a new course.
EXPECTED: Backup/restore completes without error.

4. In server settings, set 'enabletgzbackup' to on
5. Go to any course and do a backup using default settings.
6. Restore the backup to a new course.
EXPECTED: Backup/restore completes without error.

Show
NOTE: It is not feasible to reproduce the actual problem (I can't supply the 16GB backup). These tests only confirm that the zip stage of the backup process is not broken. 1. In server settings, set 'enabletgzbackup' to off (default). 2. Go to any course and do a backup using default settings. 3. Restore the backup to a new course. EXPECTED: Backup/restore completes without error. 4. In server settings, set 'enabletgzbackup' to on 5. Go to any course and do a backup using default settings. 6. Restore the backup to a new course. EXPECTED: Backup/restore completes without error.
Affected Branches:
MOODLE_27_STABLE
Fixed Branches:
MOODLE_27_STABLE, MOODLE_28_STABLE
Pull from Repository:
https://github.com/sammarshallou/moodle.git
Pull Master Branch:
~~MDL-48179~~-master
Pull Master Diff URL:
https://github.com/sammarshallou/moodle/compare/master...MDL-48179-master

Description

I'm currently investigating failures with a ~16GB backup file. In our system, anything which pauses without displaying progress for more than about 5 minutes will cause a timeout. This also applies to Firefox users regardless of installation details; Firefox has a 5 minute timeout.

The step backup_zip_contents calls backup_general_helper::get_backup_information_from_mbz which takes over five minutes (with the tgz packer) and does not display progress.

The underlying function this calls does provide progress information so it should be easy to add progress reporting to this step and avoid the timeout. I hope!

Attachments

Activity

People

Assignee:: Sam Marshall

Reporter:: Sam Marshall

Peer reviewer:: Tim Hunt

Integrator:: Sam Hemelryk

Tester:: Adrian Greeve

Participants:: Adrian Greeve, CiBoT, Dan Poltawski, Marina Glancy, Sam Hemelryk, Sam Marshall, Tim Hunt

Component watchers:: Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Dates

Created:: 12/Nov/14 7:20 AM

Updated:: 21/Nov/14 9:11 AM

Resolved:: 21/Nov/14 9:11 AM

Fix Release Date:: 12/Jan/15