Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-48194

phpunit testsuites inconsistently named

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.6.6, 2.7, 2.8
    • Fix Version/s: 2.7.4, 2.8.2
    • Component/s: Unit tests
    • Labels:
    • Testing Instructions:
      Hide
      1. Run all unit tests in the world, ever
      2. Check that we didn't break jenkins
      3. Run commands at your glee. Here are a few examples: 

        vendor/bin/phpunit --testsuite core_phpunit_testsuite
        		 
        vendor/bin/phpunit --testsuite mod_quiz_testsuite
        		 
        vendor/bin/phpunit --testsuite logstore_standard_testsuite

      Show
      Run all unit tests in the world, ever Check that we didn't break jenkins Run commands at your glee. Here are a few examples: vendor/bin/phpunit --testsuite core_phpunit_testsuite vendor/bin/phpunit --testsuite mod_quiz_testsuite vendor/bin/phpunit --testsuite logstore_standard_testsuite
    • Affected Branches:
      MOODLE_26_STABLE, MOODLE_27_STABLE, MOODLE_28_STABLE
    • Fixed Branches:
      MOODLE_27_STABLE, MOODLE_28_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-48194-master
    • Pull Master Diff URL:

      Description

      In the generated phpunit.xml, the generated testsuite names are inconsistently named:

      Core testsuites are named like:
      <testsuite name="core_phpunit_testsuite">

      All others are named:
      <testsuite name="atto_indent test suite">

      It's irritating because it makes them less guessable when wishing to run all testsuits for a component.

      They should ideally all match the same naming scheme without spaces and with the word 'testsuite' rather than two words 'test suite'

        Attachments

          Issue Links

          has been marked as being related by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-45565 Incoming messages screen duplicates Admin contact

          • Minor - Minor loss of function where workaround is possible
          • Closed

            Activity

              People

              Assignee:
              dobedobedoh Andrew Nicols
              Reporter:
              dobedobedoh Andrew Nicols
              Peer reviewer:
              Frédéric Massart
              Integrator:
              Sam Hemelryk
              Tester:
              Adrian Greeve
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                12/Jan/15