Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-48199

Page padding left is wrong when in RTL mode

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.7.3, 2.8.1
    • Fix Version/s: 2.7.4, 2.8.2
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide
      1. Using Clean theme dock a couple of blocks, and verify that there is a gutter width of about 20px on the right side of the page.
      2. Still on the same page, with the blocks still docked change language to Hebrew (he) or Arabic(ar) and verify that the dock is now on the right and that there is a gutter width of 20px on the left.
      Show
      Using Clean theme dock a couple of blocks, and verify that there is a gutter width of about 20px on the right side of the page. Still on the same page, with the blocks still docked change language to Hebrew (he) or Arabic(ar) and verify that the dock is now on the right and that there is a gutter width of 20px on the left.
    • Affected Branches:
      MOODLE_27_STABLE, MOODLE_28_STABLE
    • Fixed Branches:
      MOODLE_27_STABLE, MOODLE_28_STABLE
    • Pull Master Branch:
      MDL-48199-master

      Description

      Discovered while working on MDL-48160
      #page padding-left needs @gridGutterWidth adding when in RTL mode:

      .dir-rtl {
          &.has_dock #page {
              padding-left: @gridGutterWidth;
              padding-right: (@dockWidth + (@dockTitleMargin * 3));
          }
       

        Attachments

          Activity

            People

            • Assignee:
              lazydaisy Mary Evans
              Reporter:
              lazydaisy Mary Evans
              Integrator:
              Dan Poltawski
              Tester:
              David Monllaó
              Participants:
              Component watchers:
              Amaia Anabitarte, Bas Brands, Carlos Escobedo, Sara Arjona (@sarjona), Víctor Déniz Falcón
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                12/Jan/15