Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-48202

Clean theme blocks are 6px taller after undocking

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.8.7, 2.9.1
    • Fix Version/s: 2.8.8, 2.9.2
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide
      1. Using CLEAN theme dock two blocks.
      2. Turn editing on and test that the command icons are showing in both the un-docked blocks as well as the docked blocks.
      3. Turn editing OFF and observe that the command icons are bo longer showing in both the un-docked blocks as well as the docked blocks.
      4. UN-DOCK the two blocks and inspect with FireBug or Web Developer tool that the undocked blocks have an empty <div class="command"></div> whose height is 0
      Show
      Using CLEAN theme dock two blocks. Turn editing on and test that the command icons are showing in both the un-docked blocks as well as the docked blocks. Turn editing OFF and observe that the command icons are bo longer showing in both the un-docked blocks as well as the docked blocks. UN-DOCK the two blocks and inspect with FireBug or Web Developer tool that the undocked blocks have an empty <div class="command"></div> whose height is 0
    • Affected Branches:
      MOODLE_28_STABLE, MOODLE_29_STABLE
    • Fixed Branches:
      MOODLE_28_STABLE, MOODLE_29_STABLE
    • Pull Master Branch:
      MDL-48202-M30

      Description

      Minor display bug: with editing turned off, when you dock a block and then undock it again, the header is 6px taller than before it was docked.

      This comes from an empty <div class="commands">, added by the dock code, and styled by bootstrapbase with padding: 3px 15px (blocks.less:31). Normally, if editing is turned off, the div is not present.

      Filing this under Themes because it appears as a display issue, but it could be considered a dock bug; IMO the markup should be unchanged after the round-trip.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  6 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    14/Sep/15