Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-48202

Clean theme blocks are 6px taller after undocking

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 2.8.7, 2.9.1
    • 2.8.8, 2.9.2
    • Themes
    • MOODLE_28_STABLE, MOODLE_29_STABLE
    • MOODLE_28_STABLE, MOODLE_29_STABLE
    • MDL-48202-M30
    • Hide
      1. Using CLEAN theme dock two blocks.
      2. Turn editing on and test that the command icons are showing in both the un-docked blocks as well as the docked blocks.
      3. Turn editing OFF and observe that the command icons are bo longer showing in both the un-docked blocks as well as the docked blocks.
      4. UN-DOCK the two blocks and inspect with FireBug or Web Developer tool that the undocked blocks have an empty <div class="command"></div> whose height is 0
      Show
      Using CLEAN theme dock two blocks. Turn editing on and test that the command icons are showing in both the un-docked blocks as well as the docked blocks. Turn editing OFF and observe that the command icons are bo longer showing in both the un-docked blocks as well as the docked blocks. UN-DOCK the two blocks and inspect with FireBug or Web Developer tool that the undocked blocks have an empty <div class="command"></div> whose height is 0

    Description

      Minor display bug: with editing turned off, when you dock a block and then undock it again, the header is 6px taller than before it was docked.

      This comes from an empty <div class="commands">, added by the dock code, and styled by bootstrapbase with padding: 3px 15px (blocks.less:31). Normally, if editing is turned off, the div is not present.

      Filing this under Themes because it appears as a display issue, but it could be considered a dock bug; IMO the markup should be unchanged after the round-trip.

      Attachments

        1. empty-div.png
          empty-div.png
          154 kB
        2. MDL-48202-AFTER.jpg
          MDL-48202-AFTER.jpg
          93 kB
        3. MDL-48202-BEFORE.jpg
          MDL-48202-BEFORE.jpg
          88 kB

        Issue Links

          Testing discovered

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-50999 commands removed from the wrong place in dock code

          • Minor - Minor loss of function where workaround is possible
          • Closed
          will be (partly) resolved by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-48243 Possible inconsistancy between LTR and RTL blocks.less CSS

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Activity

            People

              lazydaisy Mary Evans
              rtandy Ryan Tandy
              Nadav Kavalerchik Nadav Kavalerchik
              Andrew Lyons Andrew Lyons
              Adrian Greeve Adrian Greeve
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                14/Sep/15