Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-48205

Badges criteria modname not translated

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.7.7, 2.8, 2.9
    • Fix Version/s: 2.7.8, 2.8.6
    • Component/s: Badges
    • Labels:
    • Testing Instructions:
      Hide

      To test you need badges enabled site-wide, a course with a multiple types of activities and completion configured for them, and a language other than English installed site-wide.

      1. As a teacher go to a course and create a badge.
      2. Add activities completion as a badge criterion.
      3. Check all activities you can check from the list.
      4. Save your criterion.
      5. Make sure that activity type is displayed correctly everywhere (for example on badge criteria page or on badge overview page)
      6. Change your default language
      7. Make sure that activity type is now displayed in the newly selected language everywhere (for example on badge criteria page or on badge overview page).
      8. Extra point for going back to editing badge criterion and checking that activity types are correctly translated everywhere on criterion config page.
      Show
      To test you need badges enabled site-wide, a course with a multiple types of activities and completion configured for them, and a language other than English installed site-wide. As a teacher go to a course and create a badge. Add activities completion as a badge criterion. Check all activities you can check from the list. Save your criterion. Make sure that activity type is displayed correctly everywhere (for example on badge criteria page or on badge overview page) Change your default language Make sure that activity type is now displayed in the newly selected language everywhere (for example on badge criteria page or on badge overview page). Extra point for going back to editing badge criterion and checking that activity types are correctly translated everywhere on criterion config page.
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_27_STABLE, MOODLE_28_STABLE, MOODLE_29_STABLE
    • Fixed Branches:
      MOODLE_27_STABLE, MOODLE_28_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-48205_master

      Description

      Hi,
      on page badges/overview.php the modname is not translated. For example 'Forum'.

      The bug might be in the file badges/criteria/award_criteria_activity.php
      on line 90:

      $str = html_writer::tag('b', '"' . ucfirst($mod->modname) . ' - ' . $mod->name . '"');

        Attachments

          Activity

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                11/May/15