Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-48221

Make forum subscription combinations less confusing with different combinations

    XMLWordPrintable

Details

    • MOODLE_28_STABLE, MOODLE_29_STABLE
    • MOODLE_29_STABLE
    • MDL-48221-master
    • Hide
      1. Run behat for mod_forum
      Setup
      1. Create a forum with optional sub
      2. Login as user 1
      3. subscribe to the forum
      4. ensure the profile setting for the user is set to subscribe to new discos
      5. Login as user 2
      6. Post four new discussions
      7. Login as user 1
      Discussion 1
      1. confirm that you are subscribed to the discussion
      2. View the discussion and click reply
      3. Confirm that the default option is to subscribe you to the discussion
      4. Post your reply
      5. Confirm that you are now subscribed to the discussion
      6. Click the reply button again
      7. Confirm that the default option is to subscribe you to the discussion
      8. Change it to not subscribed
      9. Submit your reply
      10. Confirm that you are no longer subscribed to the discussion
      11. Click the reply button again
      12. Confirm that the default option is *to subscribe you to the discussion*
      Discussion 2
      1. Edit your user preference and change to not subscribe to discussions
      2. Confirm that you are subscribed to the discussion
      3. Reply to the post
      4. Confirm that the default option is to subscribe
      5. Submit
      6. Confirm still subscribed
      7. Click Reply
      8. Confirm that the default option is to subscribed
      9. Change to not subscribe
      10. Submit
      11. Confirm no longer subscribed to discussion
      12. Click Reply
      13. Confirm that the default option is not subscribed
      14. Change to subscribe
      15. Submit
      16. Confirm that you are subscribed to the discussion
      Discussion 3
      1. Unsubscribe from the forum (this does clear discussion subs)
      2. Confirm that you are not subscribed to discussion 3
      3. View it and click reply
      4. Confirm that the default option is to *not subscribe you to the discussion*
      5. Post your reply
      6. Confirm you still aren't subscribed
      7. Reply again
      8. Confirm that the default option is to *not subscribe you to the discussion*
      9. Change it to subscribe you and submit reply
      10. Confirm now subscribed to D3
      11. Click Reply
      12. Confirm that the default option is to subscribed
      13. Change it to not subscribe you and submit reply
      14. Confirm now unsubscribed to D3
      Discussion 4
      1. Edit your user preference and change to not subscribe to discussions
      2. Confirm that you are not subscribed to discussion 4
      3. View it and click reply
      4. Confirm that the default option is to *not subscribe you to the discussion*
      5. Change it to subscribe you
      6. Post your reply
      7. Confirm you are now subscribed to D4
      8. Reply again
      9. Confirm that the default option is to subscribed
      10. Change it to not subscribe you and submit reply
      11. Confirm now not subscribed to D4
      12. Click Reply
      13. Confirm that the default option is to *not subscribe you to the discussion*
      14. Change it to subscribe you and submit reply
      15. Confirm now subscribed to D4
      Show
      Run behat for mod_forum Setup Create a forum with optional sub Login as user 1 subscribe to the forum ensure the profile setting for the user is set to subscribe to new discos Login as user 2 Post four new discussions Login as user 1 Discussion 1 confirm that you are subscribed to the discussion View the discussion and click reply Confirm that the default option is to subscribe you to the discussion Post your reply Confirm that you are now subscribed to the discussion Click the reply button again Confirm that the default option is to subscribe you to the discussion Change it to not subscribed Submit your reply Confirm that you are no longer subscribed to the discussion Click the reply button again Confirm that the default option is *to subscribe you to the discussion* Discussion 2 Edit your user preference and change to not subscribe to discussions Confirm that you are subscribed to the discussion Reply to the post Confirm that the default option is to subscribe Submit Confirm still subscribed Click Reply Confirm that the default option is to subscribed Change to not subscribe Submit Confirm no longer subscribed to discussion Click Reply Confirm that the default option is not subscribed Change to subscribe Submit Confirm that you are subscribed to the discussion Discussion 3 Unsubscribe from the forum (this does clear discussion subs) Confirm that you are not subscribed to discussion 3 View it and click reply Confirm that the default option is to *not subscribe you to the discussion* Post your reply Confirm you still aren't subscribed Reply again Confirm that the default option is to *not subscribe you to the discussion* Change it to subscribe you and submit reply Confirm now subscribed to D3 Click Reply Confirm that the default option is to subscribed Change it to not subscribe you and submit reply Confirm now unsubscribed to D3 Discussion 4 Edit your user preference and change to not subscribe to discussions Confirm that you are not subscribed to discussion 4 View it and click reply Confirm that the default option is to *not subscribe you to the discussion* Change it to subscribe you Post your reply Confirm you are now subscribed to D4 Reply again Confirm that the default option is to subscribed Change it to not subscribe you and submit reply Confirm now not subscribed to D4 Click Reply Confirm that the default option is to *not subscribe you to the discussion* Change it to subscribe you and submit reply Confirm now subscribed to D4
    • Team Beards Sprint 3
    • Small

    Description

      There is this guy named Eloy and he has:

      • In Forum X: Subscribed to forum
      • In user profile: Don't subscribe to thread when I post

      Then, he finds a really interesting post in Forum X and replies to it..

      Expected result:

      • Continues to receive posts about that thread like before.

      Actual result:

      • By participating in a thread, he becomes automatically unsubscribed! (Didn't notice the dropdown).

      This is bit crazy - as Eloy says, the solution for him is to not participate in any discussion. That would be a great shame.

      Sure there are two workarounds:

      • Eloy notices the dropdown and changes it every time he posts
      • Change that setting in profile.

      Neither are optimal workarounds and in fact, what Moodle is doing right now is really silly - it seems incredibly unlikely that anyone would ever want to become unsubscribed by participating in a thread when they were previously subscribed

      My proposal to make this much better is this:

      Have a single tickbox on the forum post 'Subscribed'

      1. That tickbox will be ticked if:
        1. They are already subscribed to the forum or thread
        2. They have 'subscribe me to threads I post in' ticked in user preferences
        3. Its a forced subscription forum (greyed out)
      2. If none of those conditions are met, it defaults unticked.

      I would also turn the user preference into 'Subcribe me to threads when I post' as a tickbox.

      Attachments

        Issue Links

          is a regression caused by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-47909 Discussion subscription does not respect $USER->autosubscribe

          • Major - Major loss of function, incorrect output
          • Closed
          is duplicated by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-48233 Discussion subscription does not respect forum subscription

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Activity

            People

              dobedobedoh Andrew Lyons
              poltawski Dan Poltawski
              Jetha Chan Jetha Chan
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Zachary Durber Zachary Durber
              Adrian Greeve, Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie
              Votes:
              4 Vote for this issue
              Watchers:
              13 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                11/May/15