Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-48235

Assignments set for Attempts Reopened Automatically Until Pass reopen even with passing grade

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 2.6.6, 2.7.3, 2.8, 2.8 regressions
    • Fix Version/s: 2.7.4, 2.8.2
    • Component/s: Assignment
    • Labels:
    • Testing Instructions:
      Hide

      Run the new unit test:

      1. vendor/bin/phpunit mod_assign_locallib_testcase

      Manual testing:

      1. Create an assignment with settings:
        • Submission types: Online text
        • Require students click submit button: Yes
        • Attempts reopened: Automatically until pass
        • Maximum attempts: Unlimited
      2. In the gradebook (categories and items) set a passing grade for the assignment to 50.
      3. Add two students to the class.
      4. As student 1, make an attempt and submit.
      5. Grade the attempt and assign a grade of 80.
      6. As student 1, verify that the attempt does not allow a new attempt.
      7. As student 2, make an attempt and submit.
      8. Grade the attempt and assign a grade of 20.
      9. As student 2, verify that the attempt does allow a new attempt.
      Show
      Run the new unit test: vendor/bin/phpunit mod_assign_locallib_testcase Manual testing: Create an assignment with settings: Submission types: Online text Require students click submit button: Yes Attempts reopened: Automatically until pass Maximum attempts: Unlimited In the gradebook (categories and items) set a passing grade for the assignment to 50. Add two students to the class. As student 1, make an attempt and submit. Grade the attempt and assign a grade of 80. As student 1, verify that the attempt does not allow a new attempt. As student 2, make an attempt and submit. Grade the attempt and assign a grade of 20. As student 2, verify that the attempt does allow a new attempt.
    • Affected Branches:
      MOODLE_26_STABLE, MOODLE_27_STABLE, MOODLE_28_STABLE
    • Fixed Branches:
      MOODLE_27_STABLE, MOODLE_28_STABLE
    • Pull Master Branch:
      MDL-48235-assign-reopen-until-pass
    • Sprint:
      BACKEND Sprint 19
    • Issue size:
      Small

      Description

      Set an assignment Submission settings to Attempts reopened Automatically until pass and Maximum attempts to 2 or more with Grade to pass set to 60. (or any other grade)
      Grade a student and give them a grade higher than the Grade to pass.
      The assignment will be Reopened even though it should not.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              mpetrowi Matt Petro
              Reporter:
              alrachels AL Rachels
              Peer reviewer:
              John Okely
              Integrator:
              David Monllaó
              Tester:
              Adrian Greeve
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                12/Jan/15