Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-48243

Possible inconsistancy between LTR and RTL blocks.less CSS

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: STABLE backlog
    • Fix Version/s: 2.7.4, 2.8.2
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide
      1. With Clean theme selected and editing on, dock at least one block.
      2. Verify that when selected the docked block opens out into the page and that the title of the block is left aligned.
      3. Verify that the block action icons '>' (dock-to-block) 'x' (show/hide) are on the right.
      4. Verify that the Editing icons are also on the right.
        SWITCH LANGUAGE to RTL - either Hebrew (he) or Arabic (ar)
      5. Test 2, 3, 4 above but verify that position of block title, block action icons and editing icons are reversed.:
        • Dock and Title on right
        • Block action icons on left
        • Editing icons on left
      Show
      With Clean theme selected and editing on, dock at least one block. Verify that when selected the docked block opens out into the page and that the title of the block is left aligned. Verify that the block action icons '>' (dock-to-block) 'x' (show/hide) are on the right. Verify that the Editing icons are also on the right. SWITCH LANGUAGE to RTL - either Hebrew (he) or Arabic (ar) Test 2, 3, 4 above but verify that position of block title, block action icons and editing icons are reversed.: Dock and Title on right Block action icons on left Editing icons on left
    • Fixed Branches:
      MOODLE_27_STABLE, MOODLE_28_STABLE
    • Pull Master Branch:
      MDL-48243_master

      Description

      Found while fixing MDL-48202 I noticed an inconsistency between the LTR mark-up and RTL mark-up for block-action.

      Where LTR mark-up gives this...

      https://github.com/moodle/moodle/blob/master/theme/bootstrapbase/less/moodle/blocks.less#L13-L18

      the RTL mark-up gives this...

      https://github.com/moodle/moodle/blob/master/theme/bootstrapbase/less/moodle/blocks.less#L240-L246

      which doesn't seem right as the margins are being applied to
      .block .header .commands whereas they should be for .block .block-action!

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                lazydaisy Mary Evans
                Reporter:
                lazydaisy Mary Evans
                Integrator:
                David Monllaó
                Tester:
                David Monllaó
                Participants:
                Component watchers:
                Bas Brands, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  12/Jan/15