Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-48269

Remove option to hide a group picture

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      Before the patch
      1. Create a new instance from an older version of Moodle
      2. Create 3 groups in two different courses
        • 1 group A with a picture, and a description text that contains a picture, group messaging ON.
        • 1 group B with a picture and the option hide picture (note the group ID), and a description text that contains a picture, group messaging ON.
        • 1 group C without a picture, and a description text that contains a picture, group messaging ON.
      3. Inspect mdl_files and note the entries for your groups

        SELECT * FROM mdl_files f LEFT JOIN mdl_groups g ON g.id = f.itemid WHERE f.component = 'group';
        

      4. Backup one of the courses. Make sure to include groups.
      After the patch
      1. Upgrade Moodle
      2. Check the columns of the groups table on the database.
      3. Confirm that the column hidepicture has been removed from the table groups.
      4. Rerun the query for "mdl_files"
      5. Confirm that the mdl_files entries for the groups B disappeared
      6. Confirm that the mdl_files entries for the groups with the "filearea" "description" have not been deleted
      Group settings
      1. Go to the group setting pages for both courses.
      2. Confirm that the groups B do not have a picture any more
      3. Confirm that the groups A still have a picture
      4. Confirm that the groups C still have no picture
      5. Confirm that the option to hide a user picture is not present
        • When you edit a group
        • When you create a group
      Restore
      1. Restore the course backup as a new course.
      2. Open the course's group settings.
      3. Confirm that group B does not have a picture any more
      4. Confirm that group A still has a picture
      5. Confirm that group C still doesn't have a picture
      Forum
      1. Edit one of the courses and set the "Group mode" to "Visible groups"
      2. Create a forum.
      3. Enrol a student s1 in the course.
      4. Add the student to all of the groups.
      5. Log in as the student.
      6. Create a forum discussion for each group.
      7. On the discussion list, confirm that the discussion for Group A has a group picture. The discussions for groups B and C should have just a default picture.
      8. View any discussion.
      9. Confirm that on the student's post, only Group A's picture is shown.
        • Note: If MDL-67959 hasn't landed yet, Group B and C's picture would be shown as the default group picture icon. Otherwise, group B and C's pictures won't be displayed on the student's post.
      Group messaging
      1. Enable outgoing email (e.g. using mailcatcher, etc.)
      2. Enrol at least one more student in each group.
      3. As s1, send a message to each group.
      4. Run cron.
      5. Check the emails that were sent to the members of each group.
      6. Confirm that the email for Group A participants shows the group picture for group A.
      7. Confirm that the emails for Groups B and C participants show a default group picture icon.
      Show
      Before the patch Create a new instance from an older version of Moodle Create 3 groups in two different courses 1 group A with a picture, and a description text that contains a picture, group messaging ON. 1 group B with a picture and the option hide picture (note the group ID), and a description text that contains a picture, group messaging ON. 1 group C without a picture, and a description text that contains a picture, group messaging ON. Inspect mdl_files and note the entries for your groups SELECT * FROM mdl_files f LEFT JOIN mdl_groups g ON g.id = f.itemid WHERE f.component = 'group'; Backup one of the courses. Make sure to include groups. After the patch Upgrade Moodle Check the columns of the groups table on the database. Confirm that the column hidepicture has been removed from the table groups . Rerun the query for " mdl_files " Confirm that the mdl_files entries for the groups B disappeared Confirm that the mdl_files entries for the groups with the " filearea " " description " have not been deleted Group settings Go to the group setting pages for both courses. Confirm that the groups B do not have a picture any more Confirm that the groups A still have a picture Confirm that the groups C still have no picture Confirm that the option to hide a user picture is not present When you edit a group When you create a group Restore Restore the course backup as a new course. Open the course's group settings. Confirm that group B does not have a picture any more Confirm that group A still has a picture Confirm that group C still doesn't have a picture Forum Edit one of the courses and set the " Group mode " to " Visible groups " Create a forum. Enrol a student s1 in the course. Add the student to all of the groups. Log in as the student. Create a forum discussion for each group. On the discussion list, confirm that the discussion for Group A has a group picture. The discussions for groups B and C should have just a default picture. View any discussion. Confirm that on the student's post, only Group A's picture is shown. Note : If MDL-67959 hasn't landed yet, Group B and C's picture would be shown as the default group picture icon. Otherwise, group B and C's pictures won't be displayed on the student's post. Group messaging Enable outgoing email (e.g. using mailcatcher, etc.) Enrol at least one more student in each group. As s1, send a message to each group. Run cron. Check the emails that were sent to the members of each group. Confirm that the email for Group A participants shows the group picture for group A. Confirm that the emails for Groups B and C participants show a default group picture icon.
    • Affected Branches:
      MOODLE_28_STABLE, MOODLE_310_STABLE, MOODLE_311_STABLE, MOODLE_38_STABLE, MOODLE_39_STABLE, MOODLE_400_STABLE
    • Fixed Branches:
      MOODLE_311_STABLE
    • Pull 3.11 Branch:
      MDL-48269-311-4
    • Pull Master Branch:
      MDL-48269-master-4
    • Story Points:
      1
    • Sprint:
      Internationals - 3.11 Sprint 5

      Description

      MDL-46416 introduces the option to delete a group picture, so I personally think that it is unnecessary to keep the option to hide a group picture. There could be some use cases for it, and maybe a handful of teachers are using it, but if we were to design the groups from scratch we would never implement such a feature.

      Before someone starts working on this we need to agree that removing the option is a good solution. See the comments on MDL-46416.

        Attachments

        1. Screenshot_1.jpg
          Screenshot_1.jpg
          209 kB
        2. Screenshot_2.jpg
          Screenshot_2.jpg
          141 kB
        3. Screenshot_3.jpg
          Screenshot_3.jpg
          62 kB
        4. Screenshot_4.jpg
          Screenshot_4.jpg
          54 kB
        5. Screenshot_5.jpg
          Screenshot_5.jpg
          47 kB

          Issue Links

            Activity

              People

              Assignee:
              jpataleta Jun Pataleta
              Reporter:
              fred Frédéric Massart
              Peer reviewer:
              Simey Lameze Simey Lameze
              Integrator:
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Tester:
              Janelle Barcega Janelle Barcega
              Participants:
              Component watchers:
              Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              1 Vote for this issue
              Watchers:
              7 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                17/May/21

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 2 days, 1 hour, 36 minutes
                  2d 1h 36m