Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-48282

user->firstaccess should be updated consistently

    XMLWordPrintable

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 2.8
    • 2.9
    • General
    • MOODLE_28_STABLE
    • MOODLE_29_STABLE
    • wip_MDL-48282_m29_firstaccess
    • Hide

      1/ run phpunit tests
      2 /create auth_manual account, login and verify first access matches first login
      3 /signup for auth_email account, confirm and login and verify first access matches first login

      Show
      1/ run phpunit tests 2 /create auth_manual account, login and verify first access matches first login 3 /signup for auth_email account, confirm and login and verify first access matches first login

    Description

      While working on an event for first login of user I realised the user->firstaccess is updated in multiple places inconsistently - instead it should be updated only form update_user_login_times() which is called only form complete_user_login()...

      Attachments

        Issue Links

          Activity

            People

              skodak Petr Skoda
              skodak Petr Skoda
              Dan Poltawski Dan Poltawski
              Sam Hemelryk Sam Hemelryk
              Rajesh Taneja Rajesh Taneja
              Adrian Greeve, David Woloszyn, Huong Nguyen, Jake Dallimore, Michael Hawkins, Stevani Andolo
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                11/May/15