Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-48282

user->firstaccess should be updated consistently

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.8
    • Fix Version/s: 2.9
    • Component/s: General
    • Labels:
    • Testing Instructions:
      Hide

      1/ run phpunit tests
      2 /create auth_manual account, login and verify first access matches first login
      3 /signup for auth_email account, confirm and login and verify first access matches first login

      Show
      1/ run phpunit tests 2 /create auth_manual account, login and verify first access matches first login 3 /signup for auth_email account, confirm and login and verify first access matches first login
    • Affected Branches:
      MOODLE_28_STABLE
    • Fixed Branches:
      MOODLE_29_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      wip_MDL-48282_m29_firstaccess
    • Pull Master Diff URL:

      Description

      While working on an event for first login of user I realised the user->firstaccess is updated in multiple places inconsistently - instead it should be updated only form update_user_login_times() which is called only form complete_user_login()...

        Attachments

          Issue Links

          caused a regression

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-54106 Delete unconfirmed users not working because firstaccess == 0

          • Major - Major loss of function, incorrect output
          • Closed
          has a non-specific relationship to

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-34901 User's first access value set to lastmodified rather than actual login time

          • Major - Major loss of function, incorrect output
          • Closed

            Activity

              People

              Assignee:
              skodak Petr Skoda
              Reporter:
              skodak Petr Skoda
              Peer reviewer:
              Dan Poltawski
              Integrator:
              Sam Hemelryk
              Tester:
              Rajesh Taneja
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                11/May/15