[MDL-48282] user->firstaccess should be updated consistently - Moodle Tracker

XML

Word

Printable

Details

Type: Improvement
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 2.8
Fix Version/s: 2.9
Component/s: General
Labels:
- Totara
- ci
- triaged

Affected Branches:
MOODLE_28_STABLE
Fixed Branches:
MOODLE_29_STABLE
Pull from Repository:
https://github.com/skodak/moodle.git
Pull Master Branch:
wip_~~MDL-48282~~_m29_firstaccess
Pull Master Diff URL:
https://github.com/skodak/moodle/compare/master...wip_MDL-48282_m29_firstaccess
Testing Instructions:

Hide

1/ run phpunit tests
2 /create auth_manual account, login and verify first access matches first login
3 /signup for auth_email account, confirm and login and verify first access matches first login

Show
1/ run phpunit tests 2 /create auth_manual account, login and verify first access matches first login 3 /signup for auth_email account, confirm and login and verify first access matches first login

Description

While working on an event for first login of user I realised the user->firstaccess is updated in multiple places inconsistently - instead it should be updated only form update_user_login_times() which is called only form complete_user_login()...

Attachments

Issue Links

caused a regression

MDL-54106 Delete unconfirmed users not working because firstaccess == 0

Closed

has a non-specific relationship to

MDL-34901 User's first access value set to lastmodified rather than actual login time

Closed

Activity

People

Assignee:: Petr Skoda

Reporter:: Petr Skoda

Peer reviewer:: Dan Poltawski

Integrator:: Sam Hemelryk

Tester:: Rajesh Taneja

Participants:: CiBoT, Dan Poltawski, Marina Glancy, Petr Skoda, Rajesh Taneja, Sam Hemelryk

Component watchers:: Adrian Greeve, David Woloszyn, Huong Nguyen, Jake Dallimore, Michael Hawkins, Stevani Andolo

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Dates

Created:: 19/Nov/14 4:59 PM

Updated:: 13/May/16 12:09 AM

Resolved:: 29/Nov/14 2:48 AM

Fix Release Date:: 11/May/15