Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-48288

Grader report's floating headers break when grade_report_showaverages is off

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 2.8 regressions, 2.8.1
    • Fix Version/s: 2.8.2
    • Component/s: Gradebook
    • Labels:
    • Testing Instructions:
      Hide
      • Create a test course of size S.
      • Go to the grader report for the course.
        • Observe that the floating headers generally work on scroll as you'd expect, with a floating footer for column averages.
        • Scroll to the bottom of the report. Observe that as you scroll right, there's a header on the bottom left marked Overall average for the averages.
      • Go to the grader report settings (Site administration -> Grades -> Report settings -> Grader report) and uncheck the box for Show column averages.
      • Go back to the grader report for the course.
        • Observe that the floating headers continue to work, albeit without the activity averages and the header for them.
      • Go back to the grader report settings and check the box for Show ranges.
      • Go back to the grader report for the course.
        • Observe that the floating headers continue to work, again without the floating footer for averages.
        • Scroll to the bottom of the report. Observe that as you scroll right, there's a header on the bottom left marked Range for the activity grading ranges.
      • Re-enable column averages.
        • Observe that the floating headers work on scroll as you'd expect, with a floating footer for column averages.
        • Scroll to the bottom of the report.
          • Observe that as you scroll right, there's a header on the bottom left marked Range for the activity grading ranges.
          • Observe that as you scroll right, there's a header on the bottom left marked Overall average for the averages.
      Show
      Create a test course of size S. Go to the grader report for the course. Observe that the floating headers generally work on scroll as you'd expect, with a floating footer for column averages. Scroll to the bottom of the report. Observe that as you scroll right, there's a header on the bottom left marked Overall average for the averages. Go to the grader report settings (Site administration -> Grades -> Report settings -> Grader report) and uncheck the box for Show column averages . Go back to the grader report for the course. Observe that the floating headers continue to work, albeit without the activity averages and the header for them. Go back to the grader report settings and check the box for Show ranges . Go back to the grader report for the course. Observe that the floating headers continue to work, again without the floating footer for averages. Scroll to the bottom of the report. Observe that as you scroll right, there's a header on the bottom left marked Range for the activity grading ranges. Re-enable column averages. Observe that the floating headers work on scroll as you'd expect, with a floating footer for column averages. Scroll to the bottom of the report. Observe that as you scroll right, there's a header on the bottom left marked Range for the activity grading ranges. Observe that as you scroll right, there's a header on the bottom left marked Overall average for the averages.
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_28_STABLE
    • Fixed Branches:
      MOODLE_28_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-48288-master
    • Sprint:
      FRONTEND Sprint 15

      Description

      As per topic - the floating headers for the grader report break completely due to a Javascript crash when grade_report_showaverages is disabled.

      Many thanks to Erin Milanese of Goshen College for identifying this problem.

      Reproduction steps
      • Create a test course of size S.
      • Go to the grader report for the course.
        • Observe that the floating headers work on scroll as you'd expect.
      • Go to the grader report settings (Site administration -> Grades -> Report settings -> Grader report) and uncheck the box for Show column averages.
      • Go back to the grader report for the course.
        • Observe that the floating headers no longer work.

        Attachments

          Activity

            People

            Assignee:
            jethac Jetha Chan
            Reporter:
            jethac Jetha Chan
            Peer reviewer:
            Andrew Nicols
            Integrator:
            Sam Hemelryk
            Tester:
            Mark Nelson
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              12/Jan/15