Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-48304

Moodle URL comparison doesn't consider anchors

    XMLWordPrintable

    Details

    • Testing Instructions:
      1. Run unit tests, they cover this.
      2. Download the test.php file and browse to it both with this patch applied and without. Check that with the patch applied only the first node is found active.
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_27_STABLE, MOODLE_28_STABLE, MOODLE_29_STABLE
    • Fixed Branches:
      MOODLE_27_STABLE, MOODLE_28_STABLE
    • Pull Master Branch:
      48304-29
    • Pull Master Diff URL:

      Description

      Whlie working on a simple solution for MDL-26226 I found a minor bug with the moodle_url::compare function.
      It doesn't consider anchor's when comparing URL's.
      As such if you add several nodes with the same URL but differing anchors to the navigation they are all found to be active.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              samhemelryk Sam Hemelryk
              Reporter:
              samhemelryk Sam Hemelryk
              Peer reviewer:
              Simey Lameze
              Integrator:
              Eloy Lafuente (stronk7)
              Tester:
              Mark Nelson
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                12/Jan/15