Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-48407

Remove some of the lines of dashes in text forum notifications

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.8.1
    • Fix Version/s: 2.9
    • Component/s: Forum
    • Labels:
    • Testing Instructions:
      Hide
      1. Use a course with a student and a teacher. Make sure the email address for the student is accessible by you.
      2. For the student, turn on text emails in the user preferences
      3. As the teacher, create a forum. Then, create a discussion as the student and make sure the student is subscribed to the thread.
      4. As the teacher, create a response in the discussion.
      5. Run cron as an admin.
      6. Check the student's email notification and make sure that the text email a) doesn't have the noisy dashes like in the screenshot in the description of this issue, and that b) the email is sensibly formatted.
      Show
      Use a course with a student and a teacher. Make sure the email address for the student is accessible by you. For the student, turn on text emails in the user preferences As the teacher, create a forum. Then, create a discussion as the student and make sure the student is subscribed to the thread. As the teacher, create a response in the discussion. Run cron as an admin. Check the student's email notification and make sure that the text email a) doesn't have the noisy dashes like in the screenshot in the description of this issue, and that b) the email is sensibly formatted.
    • Affected Branches:
      MOODLE_28_STABLE
    • Fixed Branches:
      MOODLE_29_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-48407-master
    • Pull Master Diff URL:
    • Sprint:
      Team A Sprint 1, Team '; drop tables Sprint 2
    • Issue size:
      Small

      Description

      See https://tracker.moodle.org/secure/attachment/41699/text_afterpatch.png

      I would suggest getting rid of every line of dashes except for the ones either side of the actual forum post content. Keep a blank link between the elements that are currently separated by lines of dashes.

      All those lines just add a bunch of unnecessary noise that drowns out the important stuff.

        Attachments

          Issue Links

          caused a regression

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-50276 Missing new line separator in plain text e-mails from the forum

          • Critical - Crashes server, loss of data, severe memory leak
          • Closed
          Discovered while testing

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-48227 "do not quote in replies" notice in forum emails is too loud

          • Major - Major loss of function, incorrect output
          • Closed

            Activity

              People

              Assignee:
              davecooper Dave Cooper
              Reporter:
              andyjdavis Andrew Davis
              Peer reviewer:
              John Okely
              Integrator:
              Eloy Lafuente (stronk7)
              Tester:
              Simey Lameze
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                11/May/15