[MDL-48430] Custom menu with non valid URL generates unrecoverable exception - Moodle Tracker

XML

Word

Printable

Affected Branches:
MOODLE_26_STABLE, MOODLE_28_STABLE
Fixed Branches:
MOODLE_27_STABLE, MOODLE_28_STABLE
Pull from Repository:
https://github.com/crazyserver/moodle.git
Pull Master Branch:
~~MDL-48430~~_master
Pull Master Diff URL:
https://github.com/crazyserver/moodle/compare/MDL-48430_master
Workaround:
Hide

In function convert_text_to_menu_nodes on outputcomponents.php
Do a try catch in the line:

$itemurl = new moodle_url($setting);

try {

$itemurl = new moodle_url($setting);

} catch (Exception $e){

$itemurl = null

}
Show
In function convert_text_to_menu_nodes on outputcomponents.php Do a try catch in the line: $itemurl = new moodle_url($setting); try { $itemurl = new moodle_url($setting); } catch (Exception $e){ $itemurl = null }
Difficulty:
Easy
Testing Instructions:
Hide

-Edit custom_menu setting
-Use the next text:

MDL-48430|http:///moodle.org/

-Save
-Go to a page that shows the custom menu
Show
-Edit custom_menu setting -Use the next text: MDL-48430|http:///moodle.org/ -Save -Go to a page that shows the custom menu

Using a wrong url in custom menu can generate an Exception that cannot be solved without editing database or config file.

This is the traceback of 2.6

Debug info:

Error code: invalidurl

Stack trace:

line 355 of /lib/weblib.php: moodle_exception thrown

line 2808 of /lib/outputcomponents.php: call to moodle_url->__construct()

line 2743 of /lib/outputcomponents.php: call to custom_menu::convert_text_to_menu_nodes()

....

This is caused becase parse_url in the construction of moodle_url returns false.

Participants:: CiBoT, Dan Poltawski, Eloy Lafuente (stronk7), Marina Glancy, Pau Ferrer, Rajesh Taneja, Sam Hemelryk, Simey Lameze

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo