Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-48491

Paypal plugin is sending welcome messages as admin not support contact.

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Setup.
      PayPal setup steps.
      https://moodle.org/mod/forum/discuss.php?d=171745#p977221

      1. Setup the PayPal enrolment plugin.
        1. Site-Administration -> Plugins -> Enrolments -> Manage enrol plugins.
        2. Enable PayPal.
        3. Fill in the details of your PayPal Sandbox. (see top link)
      2. Setup a new course and display.
      3. Don't add a teacher.
      4. Course-Administration -> Users -> Enrolment methods.
      5. Add method -> PayPal.
        1. Fill in details as you wish.

      To test.

      1. Login as a student.
      2. Attempt to login to a PayPal course.
      3. (Might need to run cron for the emails to be sent)

      Expected.
      Email comes from the Support Account, not a teacher or admin.

      Show
      Setup. PayPal setup steps. https://moodle.org/mod/forum/discuss.php?d=171745#p977221 Setup the PayPal enrolment plugin. Site-Administration -> Plugins -> Enrolments -> Manage enrol plugins. Enable PayPal. Fill in the details of your PayPal Sandbox. (see top link) Setup a new course and display. Don't add a teacher. Course-Administration -> Users -> Enrolment methods. Add method -> PayPal. Fill in details as you wish. To test. Login as a student. Attempt to login to a PayPal course. (Might need to run cron for the emails to be sent) Expected. Email comes from the Support Account, not a teacher or admin.
    • Affected Branches:
      MOODLE_26_STABLE, MOODLE_27_STABLE, MOODLE_28_STABLE
    • Fixed Branches:
      MOODLE_27_STABLE, MOODLE_28_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-48491-master

      Description

      The welcome messages which are being sent out from the Paypal plugin are sending messages as the site admin and not using the settings defined in the server support contact.

      In Moodle 2.6 ipn.php
      $eventdata->userfrom = empty($teacher) ? get_admin() : $teacher;

      Should read
      $eventdata->userfrom = empty($teacher) ? core_user::get_support_user() : $teacher;

        Attachments

          Activity

            People

            Assignee:
            zac Zachary Durber
            Reporter:
            derick-eld Derick Turner
            Peer reviewer:
            Zachary Durber
            Integrator:
            Andrew Nicols
            Tester:
            Dave Cooper
            Participants:
            Component watchers:
            Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona)
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              2/Feb/15