Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-48493

Automatically detect the plugin type when installing from ZIP

    Details

    • Testing Instructions:
      Hide

      Test with a wide selection of community plugins
      At the "Install plugin" admin page, when attempting to install a plugin ZIP package (downloaded from the Plugins directory or from the Github):

      • Test that there is no need to explicitly select the plugin type in advance. If the plugin declares $plugin->component in its version.php, it is used implicitly. Only when there is no such declaration available, the admin is asked to select the plugin type at the next screen.
      • If the admin is selecting the plugin type manually, and the target directory is not writeable, the warning appears. There is now a new "reload" link that let's you repeat the check. Make sure it works for you.
      • The acknowledgement has been moved to the next validation screen. There is no need to check a box now. The warning should be just displayed.
      Show
      Test with a wide selection of community plugins At the "Install plugin" admin page, when attempting to install a plugin ZIP package (downloaded from the Plugins directory or from the Github): Test that there is no need to explicitly select the plugin type in advance. If the plugin declares $plugin->component in its version.php, it is used implicitly. Only when there is no such declaration available, the admin is asked to select the plugin type at the next screen. If the admin is selecting the plugin type manually, and the target directory is not writeable, the warning appears. There is now a new "reload" link that let's you repeat the check. Make sure it works for you. The acknowledgement has been moved to the next validation screen. There is no need to check a box now. The warning should be just displayed.
    • Affected Branches:
      MOODLE_28_STABLE
    • Fixed Branches:
      MOODLE_29_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-48493-master-autodetect

      Description

      Currently, when installing an additional plugin from the manually uploaded (filepicked) ZIP file requires the admin to select the correct plugin type in advance. It would be nice to automatically detect the plugin type and display the selector only if the auto-detection fails.

      On that note, I would like to make $plugin->component required from 3.0 or so. It's been recommended for a while now (but that is for another issue).

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  6 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    11/May/15