Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-48510

Email to my private files address expires and never recovers

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 2.8 regressions, 2.8.1
    • Fix Version/s: 2.8.3
    • Component/s: Libraries, Repositories
    • Labels:
    • Testing Instructions:
      Hide
      1. Do a fresh install of Moodle and make sure the expiration period is set to "No expiry" and is not editable for "private files handler" in Site administration / ►Server / ►Incoming mail configuration / ►Message handlers / ►Email to Private files > Edit
      2. Upgrade an existing Moodle install and observer same behavior is noticed once the site is upgraded.
      3. bonus Do regression testing for the handler by trying to upload files to private files area by sending emails with attachments.
      Show
      Do a fresh install of Moodle and make sure the expiration period is set to "No expiry" and is not editable for "private files handler" in Site administration / ►Server / ►Incoming mail configuration / ►Message handlers / ►Email to Private files > Edit Upgrade an existing Moodle install and observer same behavior is noticed once the site is upgraded. bonus Do regression testing for the handler by trying to upload files to private files area by sending emails with attachments.
    • Affected Branches:
      MOODLE_28_STABLE
    • Fixed Branches:
      MOODLE_28_STABLE
    • Pull Master Branch:
      MDL-48510-master
    • Sprint:
      Team B Sprint 1

      Description

      As reported on moodle.org the my private files emailing in has a few major issues:

      1. Nowhere does the user get told that the address to email files to is going to expire, yet it does in a week in our default configuration
      2. As far as I can see from my brief look at the code, that address is never regenerated, effectively crippling this feature after 1 week without a way to recover
      3. The error message for an address expiring could be more helpful:

      - Parsing message 351
      -- Subject:    Test again x 2
      -- From:    
      -- Recipient:    
      -- Processing the message as user 2 (cmolnar).
      -- Message did not meet validation but is possibly recoverable. Fail code 64
      --> Sending a message to the user to report an verification failure.
      --- Original message retained on mail server and confirmation message sent to user.
      -- Returning to the original user.
      

      Steps to reproduce:

      1. Enable incoming email processing
      2. Enable the my private files incoming emails message handler
      3. Set the expiration to 1 hour
      4. Go to my private files and record the address
      5. Try to send an image using that email address 2 hours later
        Expected result:
      • A helpful message about expired email address is given
      • There is a way to generate a new secret email address

      Actual result:

      • The email address expires and an incorrect validation response message is sent to the user 'The message "test" could not be authenticated, since it was sent from a different email address than in your user profile. For the message to be authenticated, you need to reply to this message.'
      • There appears to be no way to generate a new secret email address

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                ankit_frenz Ankit Agarwal
                Reporter:
                poltawski Dan Poltawski
                Peer reviewer:
                Andrew Nicols
                Integrator:
                Dan Poltawski
                Tester:
                Frédéric Massart
                Participants:
                Component watchers:
                Amaia Anabitarte, Bas Brands, Carlos Escobedo, Sara Arjona (@sarjona), Víctor Déniz Falcón, Adrian Greeve, Mihail Geshoski, Peter Dias
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  2/Feb/15