Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-48519

User filters don't have labels associated with some fields

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Go to Site administration > Users > Accounts > Browse list of users
      2. Click the "Show more" filters link
        1. Confirm every input field has an associated label element
        2. Confirm that the value of that label is not empty (e.g. '', or ' ')
        3. Confirm the limiter fields have associated labels
        4. Confirm that the value of that label is not empty (e.g. '', or ' ')

      You may find the following snippet of JS handy to check this - it will spit out any labels which have a content of ' '

      Y.all('input,select').each(function(node){var type = node.getAttribute('type'), name=node.getAttribute('name'); if (name == '' || type == 'hidden' || type == 'submit' || type == 'button') { return; } var label = Y.one('label[for="' + node.getAttribute('id') + '"]'); if (label && label.get('innerHTML') == ' ') { console.log(label);}});
      

      Show
      Go to Site administration > Users > Accounts > Browse list of users Click the "Show more" filters link Confirm every input field has an associated label element Confirm that the value of that label is not empty (e.g. '', or ' ') Confirm the limiter fields have associated labels Confirm that the value of that label is not empty (e.g. '', or ' ') You may find the following snippet of JS handy to check this - it will spit out any labels which have a content of ' ' Y.all('input,select').each(function(node){var type = node.getAttribute('type'), name=node.getAttribute('name'); if (name == '' || type == 'hidden' || type == 'submit' || type == 'button') { return; } var label = Y.one('label[for="' + node.getAttribute('id') + '"]'); if (label && label.get('innerHTML') == ' ') { console.log(label);}});
    • Affected Branches:
      MOODLE_27_STABLE, MOODLE_28_STABLE
    • Fixed Branches:
      MOODLE_27_STABLE, MOODLE_28_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      m29_MDL-48519

      Description

      When browsing a list of users (Site Administration > Users > Accounts > Browse list of users), most of the fields have an empty label associated with them, meaning that users of screen readers do not know what the fields are for.

        Attachments

          Activity

            People

            Assignee:
            brianb Brian Barnes
            Reporter:
            brianb Brian Barnes
            Peer reviewer:
            David Monllaó
            Integrator:
            Andrew Nicols
            Tester:
            Simey Lameze
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              9/Mar/15