Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-48572

Grade categories calculate wrong with suspended users

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Create a course (visible groups), with an assignment. Use all the default setting which will set the maximum grade to 100.
      2. Enroll 8 students, split them in two groups.
      3. Navigate to "Grade administration > My report preferences", enable:
        • Show column averages
        • Show number of grades in averages
        • Show only active enrolments
      4. Give the grade 100 to all students except one in each group (6 will have 100, 2 are ungraded)
      5. Confirm that the grader report (All participants) shows an average of 100 (6)
      6. Change the enrolment status of one of the students (from group 1) that has a grade from "Active" to "Suspended" (from the enrolment page) .
      7. Confirm that the average is 100 (5)
      8. Switch to view only Group 1
      9. Confirm that the average is 100 (5)
      10. Confirm that the group average is 100 (2)
      11. Set 'Show only active enrolments' to 'No'
      12. Confirm that the average is 100 (6)
      13. Confirm that the group average is 100 (3)
      Show
      Create a course (visible groups), with an assignment. Use all the default setting which will set the maximum grade to 100. Enroll 8 students, split them in two groups. Navigate to "Grade administration > My report preferences", enable: Show column averages Show number of grades in averages Show only active enrolments Give the grade 100 to all students except one in each group (6 will have 100, 2 are ungraded) Confirm that the grader report (All participants) shows an average of 100 (6) Change the enrolment status of one of the students (from group 1) that has a grade from "Active" to "Suspended" (from the enrolment page) . Confirm that the average is 100 (5) Switch to view only Group 1 Confirm that the average is 100 (5) Confirm that the group average is 100 (2) Set 'Show only active enrolments' to 'No' Confirm that the average is 100 (6) Confirm that the group average is 100 (3)
    • Affected Branches:
      MOODLE_27_STABLE, MOODLE_28_STABLE
    • Fixed Branches:
      MOODLE_27_STABLE, MOODLE_28_STABLE
    • Pull Master Branch:

      Description

      To reproduce:
      -Add two students to a course
      -manually enter 90 for both in grades as course total
      -on Enrolled users page edit one student's enrolment and set Status: Suspended
      -see that Overall average for course total is 180

      I guess the average calculation takes the suspended user's grade in the summation but not in the division. So it goes like (90+90)/1. With 3 users (all have grade: 90) the average was 135 -> (90+90+90)/2

      With "Show number of grades in averages" set to Yes, you can see that the suspended user's grade is not included.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              rex Rex Lorenzo
              Reporter:
              tonik Toni Kettunen
              Peer reviewer:
              Frédéric Massart
              Integrator:
              David Monllaó
              Tester:
              Adrian Greeve
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              5 Vote for this issue
              Watchers:
              12 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                11/May/15