Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-48582

gradepass/gradefail missing from styles

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.8.1
    • Fix Version/s: 2.8.2
    • Component/s: Gradebook
    • Labels:
    • Testing Instructions:
      Hide

      In a course with some students:

      1. Add a grade item with a range of 0-100, and a grade to pass of 50
      2. Grade a number of students, both above and below 50 points
      3. View the grader report in non-editing mode and confirm:
        • Grades >50 are red
        • Grades >= 50 are green
      Show
      In a course with some students: Add a grade item with a range of 0-100, and a grade to pass of 50 Grade a number of students, both above and below 50 points View the grader report in non-editing mode and confirm: Grades >50 are red Grades >= 50 are green
    • Affected Branches:
      MOODLE_28_STABLE
    • Fixed Branches:
      MOODLE_28_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-48582-master
    • Pull Master Diff URL:
    • Sprint:
      Team A Sprint 1

      Description

      When MDL-47046 was done, the green/red styling for gradepass/gradefail was removed from grade/report/grader/style.css:
      https://github.com/moodle/moodle/commit/6ad1af094ed6d18cb614acab541e70950041c488?diff=unified#diff-afb302eee9cf937dc7811a0c590b9303L448

      I'm not sure if this was an oversight or intentional, but I can find no discussion of it in the tracker.

        Attachments

          Issue Links

          is a regression caused by

          Sub-task - Issues are sometimes broken into multiple sub-tasks. MDL-47046 Update code from UCLA to meet coding style guidelines

          • Minor - Minor loss of function where workaround is possible
          • Closed

            Activity

              People

              Assignee:
              emerrill Eric Merrill
              Reporter:
              emerrill Eric Merrill
              Peer reviewer:
              Dan Poltawski
              Integrator:
              Andrew Nicols
              Tester:
              Dave Cooper
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                12/Jan/15