Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-48582

gradepass/gradefail missing from styles

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 2.8.1
    • 2.8.2
    • Gradebook
    • MOODLE_28_STABLE
    • MOODLE_28_STABLE
    • MDL-48582-master
    • Hide

      In a course with some students:

      1. Add a grade item with a range of 0-100, and a grade to pass of 50
      2. Grade a number of students, both above and below 50 points
      3. View the grader report in non-editing mode and confirm:
        • Grades >50 are red
        • Grades >= 50 are green
      Show
      In a course with some students: Add a grade item with a range of 0-100, and a grade to pass of 50 Grade a number of students, both above and below 50 points View the grader report in non-editing mode and confirm: Grades >50 are red Grades >= 50 are green
    • Team A Sprint 1

    Description

      When MDL-47046 was done, the green/red styling for gradepass/gradefail was removed from grade/report/grader/style.css:
      https://github.com/moodle/moodle/commit/6ad1af094ed6d18cb614acab541e70950041c488?diff=unified#diff-afb302eee9cf937dc7811a0c590b9303L448

      I'm not sure if this was an oversight or intentional, but I can find no discussion of it in the tracker.

      Attachments

        Issue Links

          is a regression caused by

          Sub-task - Issues are sometimes broken into multiple sub-tasks. MDL-47046 Update code from UCLA to meet coding style guidelines

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Activity

            People

              emerrill Eric Merrill
              emerrill Eric Merrill
              Dan Poltawski Dan Poltawski
              Andrew Lyons Andrew Lyons
              Dave Cooper Dave Cooper
              Adrian Greeve, Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                12/Jan/15