Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Critical
Fix Version/s: 2.8.2
Affects Version/s: 2.8.1, 2.9
Component/s: Files API, Libraries, Messages
Labels:
- ci
- triaged

Affected Branches:
MOODLE_28_STABLE, MOODLE_29_STABLE
Fixed Branches:
MOODLE_28_STABLE
Pull from Repository:
git://github.com/andrewnicols/moodle.git
Pull Main Branch:
~~MDL-48593~~-master
Pull Main Diff URL:
https://github.com/andrewnicols/moodle/compare/8f06fff...MDL-48593-master
Difficulty:
Moderate
Testing Instructions:
Hide

With the patch NOT applied

Setup messageinbound with a GMAIL address

Enable messageinbound and the inbound files handler

Run:

php admin/tool/task/cli/schedule_task.php --execute="\tool_messageinbound\task\pickup_task"

Confirm lack of errors or failures

View your private files section, and copy the e-mail to private files address

Send a new message with an attachment to the address

Run the pickup task again

Confirm that it dies horribly with no real reason

Apply the patch

Send a new message with an attachment to the address

Run the pickup task again

Confirm that the message is now sent

For additional regression testing, I would advise testing that replying to forum posts by e-mail is also working.

Enable forum handler

Setup a new forum and ensure that your user is enroled in the course, and subscribed to the forum

Create a new discussion, and ensure that it is mailed out

Check your mailbox and reply to the message (make sure that the message inbound address is used properly - gmail sucks at this)

Run the fetch script

Confirm lack of errors

Confirm that the post was indeed made
Show
With the patch NOT applied Setup messageinbound with a GMAIL address Enable messageinbound and the inbound files handler Run: php admin/tool/task/cli/schedule_task.php --execute="\tool_messageinbound\task\pickup_task" Confirm lack of errors or failures View your private files section, and copy the e-mail to private files address Send a new message with an attachment to the address Run the pickup task again Confirm that it dies horribly with no real reason Apply the patch Send a new message with an attachment to the address Run the pickup task again Confirm that the message is now sent For additional regression testing, I would advise testing that replying to forum posts by e-mail is also working. Enable forum handler Setup a new forum and ensure that your user is enroled in the course, and subscribed to the forum Create a new discussion, and ensure that it is mailed out Check your mailbox and reply to the message (make sure that the message inbound address is used properly - gmail sucks at this) Run the fetch script Confirm lack of errors Confirm that the post was indeed made

Sprint:
FRONTEND Sprint 16

Incoming file handeling is failing with the following error messages. This is critical.

PHP Fatal error:  Call to a member function getHeaderText() on a non-object in /home/pcilms/moodle27/admin/tool/messageinbound/classes/manager.php on line 476

PHP Warning:  var_export does not handle circular references in /home/pcilms/moodle27/lib/classes/shutdown_manager.php on line 83

Exception ignored in shutdown function array (

  0 =>

  core\lock\postgres_lock_factory::__set_state(array(

     'dblockid' => 220849118,

     'db' =>

    pgsql_native_moodle_database::__set_state(array(

       'pgsql' => NULL,

       'bytea_oid' => '17',

       'last_error_reporting' => 15,

       'savepointpresent' => false,

       'database_manager' => NULL,

       'temptables' =>

      pgsql_native_moodle_temptables::__set_state(array(

         'mdb' => NULL,

         'prefix' => 'pcilms_',

         'temptables' =>

        array (

),

)),

       'tables' => NULL,

       'dbhost' => '2XXXXXXXXX',

       'dbuser' => 'moodleuser',

       'dbpass' => 'XXXXXXXXX',

       'dbname' => 'XXXXXX',

       'prefix' => 'XXXXX_',

       'dboptions' =>

      array (

        'dbpersist' => 0,

        'dbsocket' => '',

),

       'external' => false,

       'reads' => 28,

       'writes' => 0,

       'queriestime' => 0.024179935455322266,

       'debug' => 0,

       'last_sql' => NULL,

       'last_params' => NULL,

       'last_type' => 1,

       'last_extrainfo' => NULL,

       'last_time' => 1418521284.253386,

       'loggingquery' => false,

       'used_for_db_sessions' => false,

       'transactions' =>

      array (

),

       'force_rollback' => false,

       'settingshash' => 'c9a156d609a500ec3a90d9e5a94d99a3',

       'metacache' => NULL,

       'disposed' => NULL,

       'fix_sql_params_i' => 2,

       'inorequaluniqueindex' => 1,

)),

     'type' => 'cron',

     'openlocks' =>

    array (

),

)),

  1 => 'auto_release',

):Coding error detected, it must be fixed by a programmer: \core\lock\lock() has fallen out of scope without being released.

Locks must ALWAYS be released by calling $mylock->release().

root@offsite:/home/pcilms/moodle27#

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

mailsettings.jpg
211 kB
15/Dec/14 5:14 AM
message_handler_1.jpg
91 kB
15/Dec/14 5:14 AM
message_handler_2.jpg
46 kB
15/Dec/14 5:14 AM
moodle_diff.txt
443 kB
15/Dec/14 7:25 PM
private_file_profile.jpg
37 kB
15/Dec/14 5:16 AM

has a non-specific relationship to

MDL-47546 Unreleased lock throws exception outside of phpunit

Closed

is duplicated by

MDL-48703 Incoming mails throw fatal error

Closed

Testing discovered

MDL-48704 Notices running the mail pickup task

Closed

Assignee:: Andrew Lyons

Reporter:: Christopher Molnar

Peer reviewer:: Dan Poltawski

Integrator:: Eloy Lafuente (stronk7)

Tester:: Eloy Lafuente (stronk7)

Participants:: Andrew Lyons, Christopher Molnar, CiBoT, Dan Poltawski, Eloy Lafuente (stronk7), Marina Glancy, Matteo Scaramuccia

Votes:: 0 Vote for this issue

Watchers:: 5 Start watching this issue

Created:: 14/Dec/14 5:45 PM

Updated:: 01/Jan/15 12:52 AM

Resolved:: 25/Dec/14 5:50 AM

Details

With the patch NOT applied

Apply the patch

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Clockify