-
Improvement
-
Resolution: Fixed
-
Critical
-
2.8.1, 2.9, 3.0
-
MOODLE_28_STABLE, MOODLE_29_STABLE, MOODLE_30_STABLE
-
MOODLE_31_STABLE
-
MDL-48634_master -
-
Team '; drop tables Sprint 7, Team '; drop tables Sprint 9, 3.1 Sprint 3, 3.1 Sprint 4
This is a spawn off of MDL-48618. You should read that as a primer.
In versions of Moodle prior to 2.8, if you graded an item and then changed the Max Points, for the item, the existing point grade would now be used along with the new max points to compute all downstream grades.
In 2.8, the point value and max points are retained for exiting grades. This means that two students with the same number of points on an item can have drastically different grades.
Steps to reproduce
- You will need a course with two users, A and B.
- Go into your gradebook and create a new manual Grade Item, leave it at the default 100 points and change the display to 'Real (Percent)'
- Give User A a grade of '10' and save.
- You should see the user has a grade of '10 (10%)'.
- Edit the grade item and set the maximum points to 10.
- Go back to the gradebook and give User B a grade of 10 and save.
- You will now see that User A has a grade of '10 (10%)' while User B has a grade of '10 (100%)'
How do users cause it
The most common thing we see is that teachers create a grade item for something, and forget to change the max points to what they want (usually 4 points). They then go and grade people. Then they see the mistake and change the max grade to be 4, with their intent (and the previous behavior being) that a user with a grade of 4 points has a 100%.
Side effects
- From the teacher perspective, grades in the gradebook calculate in inconsistent ways. See example.png. This is made even worse with the default grade item view which just shows points - so the teacher sees they both have 30 out of 30, but one student sees they are getting a 25%, while the other sees they are getting 100%
- If you have the range row on, it shows the range of whatever the last grade in the view is - meaning that the range changes depending on sorting, filtering, and paging. See reordering.png
- The course average percents and letters are determined by the same range selected above, meaning the averages will change depending on how you have the page sorted and filtered. See reordering.png
Possible solutions (from Eloy)
- 2A) New approach is used. Exclusively. Old points and %s won't be affected ever. Only new grade_grades will.
- 2B) We continue with old approach. Exclusively. All %s will be recalculated, existing and new.
- 2C) We allow the teacher changing the item_grade to decide between applying the the maxgrade to all grade_grades or just to new ones.
- blocks
-
MDL-52522 grade_minmaxtouse not respected for overridden categories
- Closed
- caused a regression
-
MDL-55520 mod_assign resets the max grade to 100 after module editing changing all existing grades
- Closed
-
MDL-54666 Unable to update a forum activity due to scale type change
- Closed
-
MDL-53300 Incorrect check for modgrade_type
- Closed
-
MDL-57020 Unable to delete scales which are no longer used
- Closed
-
MDL-53392 Remove/fix the alert and noscript when changing grade max in mod_assign
- Closed
-
MDL-56949 Cannot rescale forum's maximum grade after one student is graded
- Open
- has a non-specific relationship to
-
MDL-31087 Implement automatic re-grading when rubric is changed
- Closed
- has been marked as being related by
-
MDL-48618 Unexpected changes on grades after upgrade to Moodle 2.8
- Closed
-
MDL-51780 Ability to determine max grade when importing.
- Closed
-
MDL-52374 Add max grade input to custom calculation
- Closed
- is a regression caused by
-
MDL-47059 Investigate/fix handling of hidden and excluded grades within natural weights
- Closed
-
MDL-47078 Sum of grades does not work with exclude empty grades
- Closed
- is duplicated by
-
MDL-48592 Changes of grademax and grademin are ignored
- Closed
-
MDL-49653 Maximum grade not adjusting correctly for grade items and assignments (urgent)
- Closed
-
MDL-49010 Some grader views show assignment range even if different from user range
- Closed
-
MDL-50319 Updating Max grade for manual grade item does not change range on user report
- Closed
- will help resolve
-
MDL-52522 grade_minmaxtouse not respected for overridden categories
- Closed