Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-48638

Typo in dmllib sends wrong error message for invalid course modules

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Visually/manually confirm that the table name listed in the patched dmllib.php correctly matches an actual table name in the Moodle db.
      2. Add the attached file to the root level of the Moodle install.
      3. Visit the page in a browser
      4. Make sure you get exception

        Invalid course module ID

        Instead of

        Can not find data record in database table course_modules.

      Show
      Visually/manually confirm that the table name listed in the patched dmllib.php correctly matches an actual table name in the Moodle db. Add the attached file to the root level of the Moodle install. Visit the page in a browser Make sure you get exception Invalid course module ID Instead of Can not find data record in database table course_modules.
    • Affected Branches:
      MOODLE_27_STABLE, MOODLE_28_STABLE
    • Fixed Branches:
      MOODLE_27_STABLE, MOODLE_28_STABLE
    • Pull Master Branch:
      MDL-48638-master

      Description

      lib/dmllib.php includes code to send the special invalidcoursemodule messages when a record in course_modules is not present, but the case accidentally checks for course_module - without the s, on line 208 (v2.8.1).

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              emerrill Eric Merrill
              Reporter:
              emerrill Eric Merrill
              Peer reviewer:
              Simey Lameze
              Integrator:
              Dan Poltawski
              Tester:
              Dan Poltawski
              Participants:
              Component watchers:
              Jake Dallimore, Jun Pataleta, Jake Dallimore, Jun Pataleta, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                12/Jan/15