Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-48638

Typo in dmllib sends wrong error message for invalid course modules

    XMLWordPrintable

Details

    • MOODLE_27_STABLE, MOODLE_28_STABLE
    • MOODLE_27_STABLE, MOODLE_28_STABLE
    • MDL-48638-master
    • Hide
      1. Visually/manually confirm that the table name listed in the patched dmllib.php correctly matches an actual table name in the Moodle db.
      2. Add the attached file to the root level of the Moodle install.
      3. Visit the page in a browser
      4. Make sure you get exception

        Invalid course module ID

        Instead of

        Can not find data record in database table course_modules.

      Show
      Visually/manually confirm that the table name listed in the patched dmllib.php correctly matches an actual table name in the Moodle db. Add the attached file to the root level of the Moodle install. Visit the page in a browser Make sure you get exception Invalid course module ID Instead of Can not find data record in database table course_modules.

    Description

      lib/dmllib.php includes code to send the special invalidcoursemodule messages when a record in course_modules is not present, but the case accidentally checks for course_module - without the s, on line 208 (v2.8.1).

      Attachments

        Issue Links

          is a regression caused by

          Improvement - An enhancement to an existing Moodle feature. MDL-19689 new $strictness parameter in $DB->get_record() DML method

          • Major - Major loss of function, incorrect output
          • Closed

          Activity

            People

              emerrill Eric Merrill
              emerrill Eric Merrill
              Simey Lameze Simey Lameze
              Dan Poltawski Dan Poltawski
              Dan Poltawski Dan Poltawski
              David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo, Adrian Greeve, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                12/Jan/15