Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-48643

Confirmation dialogs cause the page to scroll to top

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.8 regressions, 2.8.1
    • Fix Version/s: 2.8.2
    • Component/s: JavaScript
    • Labels:
    • Testing Instructions:
      Hide

      You will need a course with a bunch of enrollments and files in it (like a Small test course).

      Remove user role

      1. Go into the course, then Course Admin > Users > Enrolled Users
      2. Scroll down some
      3. Click the X next to a the role of a user
      4. When the popup appears confirm:
        • The page didn't jump to the top
        • The background greyed
        • You cannot scroll
      5. Hit cancel
      6. Confirm:
        • The grey overlay and dialog disappear
        • The user maintained their role
      7. Click the X next to a the role of a user.
      8. Click Remove
      9. Confirm:
        • The grey overlay and dialog disappear
        • The users role is removed
      10. Reload the page and confirm that the changes stuck

      Course DnD upload

      1. Go to the course page and turn on editing
      2. Scroll down the page some
      3. Drag a zip file into the course
      4. When the pop-up appears, confirm:
        • The page didn't jump to the top
        • The background greyed
        • You cannot scroll
      5. Hit cancel
      6. Confirm:
        • The grey overlay and dialog disappear
        • No file was added to the course
      7. Drag a zip file into the course
      8. When the popup appears, select Create file resource and click upload
      9. Confirm:
        • The grey overlay and dialog disappear
        • A file resource was created with the zip file
      10. Reload the page and confirm that the changes stuck

      Activity delete

      1. Go to the course page and turn on editing
      2. Scroll down the page some
      3. Click Edit next to an activity, then Delete
      4. When the pop-up appears, confirm:
        • The page didn't jump to the top
        • The background greyed
        • You cannot scroll
      5. Hit No
      6. Confirm:
        • The grey overlay and dialog disappear
        • The activity remains in the course
      7. Click Edit next to an activity, then Yes
      8. Confirm:
        • The grey overlay and dialog disappear
        • The activity is removed from the course
      9. Reload the page and confirm that the changes stuck
      Show
      You will need a course with a bunch of enrollments and files in it (like a Small test course). Remove user role Go into the course, then Course Admin > Users > Enrolled Users Scroll down some Click the X next to a the role of a user When the popup appears confirm: The page didn't jump to the top The background greyed You cannot scroll Hit cancel Confirm: The grey overlay and dialog disappear The user maintained their role Click the X next to a the role of a user. Click Remove Confirm: The grey overlay and dialog disappear The users role is removed Reload the page and confirm that the changes stuck Course DnD upload Go to the course page and turn on editing Scroll down the page some Drag a zip file into the course When the pop-up appears, confirm: The page didn't jump to the top The background greyed You cannot scroll Hit cancel Confirm: The grey overlay and dialog disappear No file was added to the course Drag a zip file into the course When the popup appears, select Create file resource and click upload Confirm: The grey overlay and dialog disappear A file resource was created with the zip file Reload the page and confirm that the changes stuck Activity delete Go to the course page and turn on editing Scroll down the page some Click Edit next to an activity, then Delete When the pop-up appears, confirm: The page didn't jump to the top The background greyed You cannot scroll Hit No Confirm: The grey overlay and dialog disappear The activity remains in the course Click Edit next to an activity, then Yes Confirm: The grey overlay and dialog disappear The activity is removed from the course Reload the page and confirm that the changes stuck
    • Affected Branches:
      MOODLE_28_STABLE
    • Fixed Branches:
      MOODLE_28_STABLE
    • Pull Master Branch:
      MDL-48643-master

      Description

      Anything that uses M.core.confirm() causes the page to jump to the top left scroll position. The biggest place this is a problem is when you go to delete an activity or resource for a course - on big courses this becomes a huge pain.

      It only happens in 2.8.x, not 2.7.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  12/Jan/15