Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-48657

Replace or remove password_compat_not_supported()

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Duplicate
    • Affects Version/s: 2.7.3, 2.8.1, 2.9
    • Fix Version/s: None
    • Component/s: Authentication
    • Labels:
      None
    • Affected Branches:
      MOODLE_27_STABLE, MOODLE_28_STABLE, MOODLE_29_STABLE

      Description

      As discussed in MDL-48636 we currently use a specific behavioural test to determine if a site supports the new password hashing algorithm. This has two problems:

      1) There has been suggestions that it is unreliable, see:
      https://github.com/ircmaxell/password_compat/issues/10#issuecomment-15032835
      2) The test is quite slow, so the result needs to be cached, which adds some extra complexity to the code.

      Since Moodle 2.7+ now requires php 5.4 it is reasonable to expect that site's will support the new password hashing scheme. Therefore for version 2.7 and above we can either:

      1) Replace the test with a faster and more reliable PHP version check
      2) Remove the test altogether and rely on moodle version checks

      This is not urgent but would be good thing to tidy up.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              simoncoggins Simon Coggins
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: