Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.5.3
    • Fix Version/s: None
    • Component/s: Language
    • Labels:
      None
    • Environment:
      All
    • Database:
      Any
    • Affected Branches:
      MOODLE_15_STABLE
    • Rank:
      14701

      Description

      Script: login/signup.php

      PHP E_ALL

      Notice: Undefined property: lastname in C:\Programme\wampserver\www\mvhs\lib\moodlelib.php(4460) : eval()'d code on line 1

      Notice: Undefined property: lastname in C:\Programme\wampserver\www\mvhs\lib\moodlelib.php(4460) : eval()'d code on line 1

      Reason: lib/moodlelib.php uses $a->firstname as fullname.

      $a->lastname does not exist and is not defined (line 3615).

      FIX: language file de/moodle.php - for $string['emailconfirmation'] delete $a->lastname.

        Activity

        Hide
        Martin Dougiamas added a comment -

        From oen roggemans (koen at roggemans.net) Wednesday, 1 March 2006, 10:25 PM:

        Hm, no, must not be deleted. It must be something different

        That string is meant to display the lastname too.

        Do your user fields contain last names?

        From Tobias (th at hauser-wenz.de) Wednesday, 1 March 2006, 10:41 PM:

        Yes, they do. I have signed up a new user with lastname. And the global configuration for fullnamedisplay is firstname plus lastname.

        I have looked at other language packs and there the $string['emailconfirmation'] does only contain the firstname. I found one place in lib/moodlelib.php where the firstname is set to fullname (line 3645) - I presume, thats the problem - and I var_dump-ed the $result-string in line 4460. That produced a string with $a->lastname out of the language pack vor the eval(). Therefore the conclusion, to change the $string['emailconfirmation'] in the de-language pack.

        From oen roggemans (koen at roggemans.net) Wednesday, 1 March 2006, 10:56 PM:

        Yes, now I see. It is an error in the de langpack.

        I think Ralph (as I remember correct) wanted to have first name and lastname displayed there. I'll contact him to take a look at it and keep you informed.

        Thank you for reporting

        From dialoge dialoge (rh at dialoge.net) Wednesday, 1 March 2006, 11:51 PM:

        Yes it is correct. We have to delete this string in the emailconfirmation.

        I remember when we changed this, it was the correct way. Perhaps there are changes in the use of first-/lastname in the code.

        Koen, can you change it in the german file. I can't do it in the next days.

        Show
        Martin Dougiamas added a comment - From oen roggemans (koen at roggemans.net) Wednesday, 1 March 2006, 10:25 PM: Hm, no, must not be deleted. It must be something different That string is meant to display the lastname too. Do your user fields contain last names? From Tobias (th at hauser-wenz.de) Wednesday, 1 March 2006, 10:41 PM: Yes, they do. I have signed up a new user with lastname. And the global configuration for fullnamedisplay is firstname plus lastname. I have looked at other language packs and there the $string ['emailconfirmation'] does only contain the firstname. I found one place in lib/moodlelib.php where the firstname is set to fullname (line 3645) - I presume, thats the problem - and I var_dump-ed the $result-string in line 4460. That produced a string with $a->lastname out of the language pack vor the eval(). Therefore the conclusion, to change the $string ['emailconfirmation'] in the de-language pack. From oen roggemans (koen at roggemans.net) Wednesday, 1 March 2006, 10:56 PM: Yes, now I see. It is an error in the de langpack. I think Ralph (as I remember correct) wanted to have first name and lastname displayed there. I'll contact him to take a look at it and keep you informed. Thank you for reporting From dialoge dialoge (rh at dialoge.net) Wednesday, 1 March 2006, 11:51 PM: Yes it is correct. We have to delete this string in the emailconfirmation. I remember when we changed this, it was the correct way. Perhaps there are changes in the use of first-/lastname in the code. Koen, can you change it in the german file. I can't do it in the next days.
        Hide
        Michael Blake added a comment -

        assign to a valid user

        Show
        Michael Blake added a comment - assign to a valid user
        Hide
        Michael Blake added a comment -

        assign to a valid user

        Show
        Michael Blake added a comment - assign to a valid user

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: