[MDL-48702] Improve course log export resource consumption and reliability (backport of MDL-34867) - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 2.7.7, 2.8.1
Fix Version/s: 2.7.8, 2.8.6
Component/s: Logging
Labels:
- release_notes
- triaged

Affected Branches:
MOODLE_27_STABLE, MOODLE_28_STABLE
Fixed Branches:
MOODLE_27_STABLE, MOODLE_28_STABLE
Pull from Repository:
https://github.com/andyjdavis/moodle.git
Testing Instructions:
Hide

Run the unit tests in:

admin/tool/log/store/standard/tests/store_test.php; and

admin/tool/log/store/legacy/tests/store_test.php

Navigate to Site administration > Reports > Logs and select “Standard log” from the dropdown

Click “Get these logs” (If that option is not available then you are already viewing the standard log by default.)

Check that you can view log data.

Re-enable legacy logging (You can enable legacy logging from Site administration > Plugins > Logging > Manage log stores. Select the option "Log legacy data" and save changes).
Note: Since M27, log data is no longer stored in the table mdl_log by default but we will need some data generated in order to verify the downloaded data.

From the Logs page select the “Legacy log” option from the dropdown and select “Get these logs"

Check you can view log data
Show
Run the unit tests in: admin/tool/log/store/standard/tests/store_test.php; and admin/tool/log/store/legacy/tests/store_test.php Navigate to Site administration > Reports > Logs and select “Standard log” from the dropdown Click “Get these logs” (If that option is not available then you are already viewing the standard log by default.) Check that you can view log data. Re-enable legacy logging (You can enable legacy logging from Site administration > Plugins > Logging > Manage log stores. Select the option "Log legacy data" and save changes). Note: Since M27, log data is no longer stored in the table mdl_log by default but we will need some data generated in order to verify the downloaded data. From the Logs page select the “Legacy log” option from the dropdown and select “Get these logs" Check you can view log data

Description

See ~~MDLSITE-3683~~. If you have a lot of data logged you can easily start running into memory allocation errors when you start retrieving log data. The calling code can cap the number of records it asks for but this is far from ideal if you are trying to aggregate log data.

Attachments

Issue Links

has a non-specific relationship to

MDL-49145 log report error for event contexts

Closed

MDL-48595 Log exports still consume all memory and fail

Closed

MDL-34867 Improve course log export resource consumption and reliability

Closed

has been marked as being related by

MDL-48729 Prevent fatal error if retrieving legacy log data fails

Closed

is blocked by

MDL-49162 report_log Event context link not working after MDL-34867

Closed

will help resolve

MDLSITE-3683 Overview stats page not displaying

Resolved

(1 will help resolve)

Activity

People

Assignee:: Andrew Davis

Reporter:: Andrew Davis

Peer reviewer:: Dan Poltawski

Integrator:: Dan Poltawski

Tester:: Dave Cooper

Participants:: Andrew Davis, Andrew Lyons, CiBoT, Dan Poltawski, Dave Cooper, David Monllaó, Eloy Lafuente (stronk7), Petr Skoda

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 0 Vote for this issue

Watchers:: 5 Start watching this issue

Dates

Created:: 24/Dec/14 11:19 PM

Updated:: 21/Apr/15 6:27 PM

Resolved:: 15/Apr/15 8:03 AM

Fix Release Date:: 11/May/15