Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-48720

Retaining forum subscriptions on forum post move is problematic

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.8.1, 2.9
    • Fix Version/s: 2.8.3
    • Component/s: Forum
    • Testing Instructions:
      Hide
      1. Create two forums ('Maths', 'General chit chat') in a course
      2. As teacher1, post about a joke in the Maths forum
      3. As student1, subscribe to the 'Maths' forum only
      4. As student2, subscribe to the 'General chit chat' forum only
      5. As student3, subscribe to the newly created discussion
      6. As student4, subscribe to the both forums, and unsubscribe from the new discussion
      7. As teacher1 move the post from 'Maths' to 'General chit chat'
      8. Observe the following:
        • Student1 is not subscribed to the discussion
        • Student2 is subscribed to the discussion
        • Student3 is subscribed to the discussion
        • Student4 is not subscribed to the discussion
      Show
      Create two forums ('Maths', 'General chit chat') in a course As teacher1, post about a joke in the Maths forum As student1, subscribe to the 'Maths' forum only As student2, subscribe to the 'General chit chat' forum only As student3, subscribe to the newly created discussion As student4, subscribe to the both forums, and unsubscribe from the new discussion As teacher1 move the post from 'Maths' to 'General chit chat' Observe the following: Student1 is not subscribed to the discussion Student2 is subscribed to the discussion Student3 is subscribed to the discussion Student4 is not subscribed to the discussion
    • Affected Branches:
      MOODLE_28_STABLE, MOODLE_29_STABLE
    • Fixed Branches:
      MOODLE_28_STABLE
    • Pull Master Branch:
      MDL-48720-master

      Description

      Steps to reproduce:

      1. Create two forums ('Maths', 'General chit chat') in a course
      2. As student1, subscribe to the posts in 'Maths' but not 'General chit chat'
      3. As student2, post about a joke in the Maths forum
      4. As teacher1 move the post from 'Maths' to 'General chit chat' before the end of the editing window (as its offtopic for the study forum)

      Expected result:

      • Student2 doesn't receive copies of student1's forum post which is offtopic

      Actual result:

      • Student2 receives copies of the off-topic post

      Further discussion:

      Moving the subscriptions before the editing window is over (and thus, posts have gone out) is really confusing to the user, because they will get notifications about forum posts in a forum they are not subscribed to without any indication of why it happened. But even after the editing window is over - a frequent reason for forum post moves will be done as a moderating action to prevent offtopic discussions from carrying out in the wrong forum. I do not think it makes sense to retain 'forum' subscribers (rather than thread subscribers) in many scenarios

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  2/Feb/15