Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-48729

Prevent fatal error if retrieving legacy log data fails

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.9
    • Fix Version/s: 2.9
    • Component/s: Logging
    • Labels:
    • Testing Instructions:
      Hide

      Go to side admin > plugins > logging > manage log stores and make Legacy Log visible. Both standard and legacy should now be visible (if they aren't make them both visible).

      In Legacy Log's own settings tick loglegacy.

      Go into a course and select course admin > reports > logs. Select "legacy log" from one of the drop downs and check that you can view log entries. There will only be one or two as you just turned it on.

      Show
      Go to side admin > plugins > logging > manage log stores and make Legacy Log visible. Both standard and legacy should now be visible (if they aren't make them both visible). In Legacy Log's own settings tick loglegacy. Go into a course and select course admin > reports > logs. Select "legacy log" from one of the drop downs and check that you can view log entries. There will only be one or two as you just turned it on.
    • Affected Branches:
      MOODLE_29_STABLE
    • Fixed Branches:
      MOODLE_29_STABLE
    • Pull Master Branch:
      MDL-48729_legacy_log_error

      Description

      MDL-34867 introduced a changed that means that the legacy log will now produce a fatal error if retrieving log data fails. See Petr's comment at https://tracker.moodle.org/browse/MDL-48702?focusedCommentId=331467&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-331467

      Note that this change was introduced by MDL-34867 into master only.

      MDL-48702 is backporting that change so this fix to 2.7 and 2.8 will have to wait for that backporting to occur.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              andyjdavis Andrew Davis
              Reporter:
              andyjdavis Andrew Davis
              Peer reviewer:
              Petr Skoda
              Integrator:
              Dan Poltawski
              Tester:
              John Okely
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                11/May/15