[MDL-48729] Prevent fatal error if retrieving legacy log data fails - Moodle Tracker

XML

Word

Printable

Affected Branches:
MOODLE_29_STABLE
Fixed Branches:
MOODLE_29_STABLE
Pull from Repository:
https://github.com/andyjdavis/moodle.git
Pull Master Branch:
~~MDL-48729~~_legacy_log_error
Pull Master Diff URL:
https://github.com/andyjdavis/moodle/compare/master...MDL-48729_legacy_log_error
Testing Instructions:

Hide

Go to side admin > plugins > logging > manage log stores and make Legacy Log visible. Both standard and legacy should now be visible (if they aren't make them both visible).

In Legacy Log's own settings tick loglegacy.

Go into a course and select course admin > reports > logs. Select "legacy log" from one of the drop downs and check that you can view log entries. There will only be one or two as you just turned it on.

Show
Go to side admin > plugins > logging > manage log stores and make Legacy Log visible. Both standard and legacy should now be visible (if they aren't make them both visible). In Legacy Log's own settings tick loglegacy. Go into a course and select course admin > reports > logs. Select "legacy log" from one of the drop downs and check that you can view log entries. There will only be one or two as you just turned it on.

Note that this change was introduced by ~~MDL-34867~~ into master only.

~~MDL-48702~~ is backporting that change so this fix to 2.7 and 2.8 will have to wait for that backporting to occur.

has a non-specific relationship to

MDL-48702 Improve course log export resource consumption and reliability (backport of MDL-34867)

is a regression caused by

MDL-34867 Improve course log export resource consumption and reliability

will help resolve

MDL-48595 Log exports still consume all memory and fail

Participants:: Andrew Davis, Andrew Lyons, CiBoT, Dan Poltawski, John Okely, Petr Skoda

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo