[MDL-48765] Use of non-breaking space in enrol instances page causes alignment issue - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Trivial
Resolution: Fixed
Affects Version/s: 2.9
Fix Version/s: 2.7.5, 2.8.3
Component/s: Enrolments
Labels:
- ci
- patch
- release_notes
- triaged

Affected Branches:
MOODLE_29_STABLE
Fixed Branches:
MOODLE_27_STABLE, MOODLE_28_STABLE
Pull from Repository:
git://github.com/gurgus/moodle.git
Pull Master Branch:
~~MDL-48765~~-master
Pull Master Diff URL:
https://github.com/mackensen/moodle/compare/MDL-48765-master
Testing Instructions:
1. Create a course with at least one enrolment method.
2. View the enrolment instance page in a browser. Resize to a small enough breakpoint that the icons stack vertically.
3. Verify that the edit icons align.

Description

The up/down and edit icons on enrol/instances.php are separated by a non-breaking space. This is done via an implode() call. This causes an alignment issue at small breakpoints when the icons stack vertically, because the last icon in the set is not followed by a non-breaking space. If there needs to be spacing between the icons surely this can be done with CSS, and there's already some padding applied.

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

enrol instance alignment.png
59 kB
08/Jan/15 8:16 AM

Activity

People

Assignee:: Charles Fulton

Reporter:: Charles Fulton

Peer reviewer:: Dave Cooper

Integrator:: David Monllaó

Tester:: Marina Glancy

Participants:: Andrew Lyons, Charles Fulton, CiBoT, Dan Poltawski, Dave Cooper, David Monllaó, Marina Glancy

Component watchers:: Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Laurent David, Raquel Ortega, Sara Arjona (@sarjona)

Votes:: 7 Vote for this issue

Watchers:: 5 Start watching this issue

Dates

Created:: 08/Jan/15 8:10 AM

Updated:: 30/Jan/15 12:03 AM

Resolved:: 23/Jan/15 6:31 PM

Fix Release Date:: 2/Feb/15