Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-48823

Improve performance when saving administration settings

    XMLWordPrintable

Details

    • MOODLE_27_STABLE, MOODLE_28_STABLE, MOODLE_29_STABLE
    • MOODLE_27_STABLE, MOODLE_28_STABLE
    • MDL-48823_master
    • Hide
      1. Set MDL_PERF constants in your config.php
      2. Go to admin/settings.php?section=assignfeedback_editpdf
      3. Add a new icon
      4. Save changes
      5. Do you see DB reads/writes: in your footer? Note the value
      6. Revert this issue's patch
      7. Add a new icon and save changes again
      8. Do you see DB reads/writes: in your footer?
      9. The current value (without the patch) SHOULD be higher than with the patch
      Show
      Set MDL_PERF constants in your config.php Go to admin/settings.php?section=assignfeedback_editpdf Add a new icon Save changes Do you see DB reads/writes: in your footer? Note the value Revert this issue's patch Add a new icon and save changes again Do you see DB reads/writes: in your footer? The current value (without the patch) SHOULD be higher than with the patch

    Description

      admin_write_settings() includes a admin_get_root(true) as part of it's code and all the calls to admin_write_settings() in core are refreshing again the admin tree. We could get rid of the admin_write_settings() one in master, in stables we could add an extra $reloadadmintree argument to admin_write_settings() that can default to true and change the calls to admin_write_settings($data, false)

      Attachments

        Issue Links

          has a non-specific relationship to

          Improvement - An enhancement to an existing Moodle feature. MDL-48921 Query in URL is lost in admin settings search page

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Activity

            People

              dmonllao David Monllaó
              dmonllao David Monllaó
              Rajesh Taneja Rajesh Taneja
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                2/Feb/15