Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-48823

Improve performance when saving administration settings

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Set MDL_PERF constants in your config.php
      2. Go to admin/settings.php?section=assignfeedback_editpdf
      3. Add a new icon
      4. Save changes
      5. Do you see DB reads/writes: in your footer? Note the value
      6. Revert this issue's patch
      7. Add a new icon and save changes again
      8. Do you see DB reads/writes: in your footer?
      9. The current value (without the patch) SHOULD be higher than with the patch
      Show
      Set MDL_PERF constants in your config.php Go to admin/settings.php?section=assignfeedback_editpdf Add a new icon Save changes Do you see DB reads/writes: in your footer? Note the value Revert this issue's patch Add a new icon and save changes again Do you see DB reads/writes: in your footer? The current value (without the patch) SHOULD be higher than with the patch
    • Affected Branches:
      MOODLE_27_STABLE, MOODLE_28_STABLE, MOODLE_29_STABLE
    • Fixed Branches:
      MOODLE_27_STABLE, MOODLE_28_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-48823_master

      Description

      admin_write_settings() includes a admin_get_root(true) as part of it's code and all the calls to admin_write_settings() in core are refreshing again the admin tree. We could get rid of the admin_write_settings() one in master, in stables we could add an extra $reloadadmintree argument to admin_write_settings() that can default to true and change the calls to admin_write_settings($data, false)

        Attachments

        1. example_refresh_object.php
          0.4 kB
          David Monllaó
        2. example_refresh.php
          0.3 kB
          David Monllaó

          Issue Links

            Activity

              People

              Assignee:
              dmonllao David Monllaó
              Reporter:
              dmonllao David Monllaó
              Peer reviewer:
              Rajesh Taneja
              Integrator:
              Eloy Lafuente (stronk7)
              Tester:
              Eloy Lafuente (stronk7)
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                2/Feb/15