[MDL-48830] Inaccurate query in get_capability_info() - Moodle Tracker

XML

Word

Printable

Testing Instructions:

Hide

Run accesslib unit tests and confirm there are no failures.

Show
Run accesslib unit tests and confirm there are no failures.
Affected Branches:
MOODLE_26_STABLE, MOODLE_27_STABLE, MOODLE_28_STABLE, MOODLE_29_STABLE
Fixed Branches:
MOODLE_27_STABLE, MOODLE_28_STABLE
Pull from Repository:
https://github.com/micaherne/moodle.git
Pull Master Branch:
~~MDL-48830~~-m
Pull Master Diff URL:
https://github.com/micaherne/moodle/compare/MDL-48830-m

The statement used in get_capability_info() in accesslib.php to get all capabilities is:

$caps = $DB->get_records('capabilities', array(), 'id, name, captype, riskbitmask');

This obviously returns the records required but seems slightly wrong as the id is unique, so the rest of the sort parameters are redundant.