Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-48897

Error displayed while editing content page jumps in the lesson (Backport of MDL-48675)

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • 2.7.8, 2.8.6
    • 2.7.4, 2.8.2
    • Lesson
    • MOODLE_27_STABLE, MOODLE_28_STABLE
    • MOODLE_27_STABLE, MOODLE_28_STABLE
    • Hide

      Testing is exactly the same as in MDL-48675

      Test that MDL-48675 is fixed

      Create a lesson with some content pages.
      Edit one of these page and change a jump.
      Verify no notice or warning is displayed when saving the modified page.

      Test that MDL-32343 and MDL-31778 are fixed

      Create a lesson with a cluster:

      • some content page
      • a cluster page to mark the cluster's beginning
      • various questions with the right answer jump set to the above cluster
      • and end of cluster page to mark the cluster end
      • some content page

      Verify that you can edit pages of this lesson without producing any error or warning
      Edit the cluster page "Page title" and "Page contents" (don't change the jump !) save your changes and verify that the jump is still set to "Unseen question within a cluster" and not changed to "Next page".

      Show
      Testing is exactly the same as in MDL-48675 Test that MDL-48675 is fixed Create a lesson with some content pages. Edit one of these page and change a jump. Verify no notice or warning is displayed when saving the modified page. Test that MDL-32343 and MDL-31778 are fixed Create a lesson with a cluster: some content page a cluster page to mark the cluster's beginning various questions with the right answer jump set to the above cluster and end of cluster page to mark the cluster end some content page Verify that you can edit pages of this lesson without producing any error or warning Edit the cluster page "Page title" and "Page contents" (don't change the jump !) save your changes and verify that the jump is still set to "Unseen question within a cluster" and not changed to "Next page".

      This backport is about fixing several errors that arise when editing content and cluster pages in lesson.
      it fixes at the same time problems described in MDL-48675, MDL-32343 and MDL-31778.
      As Dan Poltawski said in MDL-48675 comments:
      I understand that its verging on an API change, but this seems like a worthwhile bug to fix.
      I see that this is not a clean back-port - so instead i'm going to propose a backport request.
      And we can integrate the fix (with potentially risky API change) later. Though I don't tend to regard this api change as too risky.

            jmvedrine Jean-Michel Vedrine
            jmvedrine Jean-Michel Vedrine
            Mark Nelson Mark Nelson
            David Monllaó David Monllaó
            Andrew Lyons Andrew Lyons
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.