Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-48924

Small tgz backup (enabletgzbackups) fixes

    XMLWordPrintable

Details

    • MOODLE_27_STABLE, MOODLE_28_STABLE
    • MOODLE_27_STABLE, MOODLE_28_STABLE
    • tgz_fixing
    • Hide

      1) Edit admin/settings/development.php, change default for enabletgzbackups 0 => 1
      2) Re-init & run phpunit
      3) Expect all pass, not fails in questionlib & courselib.

      Show
      1) Edit admin/settings/development.php, change default for enabletgzbackups 0 => 1 2) Re-init & run phpunit 3) Expect all pass, not fails in questionlib & courselib.

    Description

      We have been experimenting with using tgz backup ($CFG->enabletgzbackups) and even setting it as the default.

      With the default changed, a few tests fail, and it exposed a problem with get_file_packer used in some contexts on backups without the correct mimetype argument. After auditing all such usage I came up with only one other place in core which seems incorrect.

      Anyway, providing patch to get these places fixed up...

      Attachments

        Activity

          People

            tlevi Tony Levi
            tlevi Tony Levi
            Sam Marshall Sam Marshall
            Andrew Lyons Andrew Lyons
            Zachary Durber Zachary Durber
            Adrian Greeve, David Woloszyn, Huong Nguyen, Jake Dallimore, Michael Hawkins, Stevani Andolo
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:
              9/Mar/15