[MDL-48924] Small tgz backup (enabletgzbackups) fixes - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 2.7.5, 2.8.3
Fix Version/s: 2.7.6, 2.8.4
Component/s: Backup, Unit tests
Labels:
- ci
- netspot
- partner
- patch
- triaged

Affected Branches:
MOODLE_27_STABLE, MOODLE_28_STABLE
Fixed Branches:
MOODLE_27_STABLE, MOODLE_28_STABLE
Pull from Repository:
https://github.com/tlevi/moodle
Pull Main Branch:
tgz_fixing
Pull Main Diff URL:
https://github.com/tlevi/moodle/compare/master...tgz_fixing
Testing Instructions:

Hide

1) Edit admin/settings/development.php, change default for enabletgzbackups 0 => 1
2) Re-init & run phpunit
3) Expect all pass, not fails in questionlib & courselib.

Show
1) Edit admin/settings/development.php, change default for enabletgzbackups 0 => 1 2) Re-init & run phpunit 3) Expect all pass, not fails in questionlib & courselib.

Description

We have been experimenting with using tgz backup ($CFG->enabletgzbackups) and even setting it as the default.

With the default changed, a few tests fail, and it exposed a problem with get_file_packer used in some contexts on backups without the correct mimetype argument. After auditing all such usage I came up with only one other place in core which seems incorrect.

Anyway, providing patch to get these places fixed up...

Attachments

Activity

People

Assignee:: Tony Levi

Reporter:: Tony Levi

Peer reviewer:: Sam Marshall

Integrator:: Andrew Lyons

Tester:: Zachary Durber

Participants:: Andrew Lyons, CiBoT, Dan Poltawski, Sam Marshall, Tim Hunt, Tony Levi, Zachary Durber

Votes:: 0 Vote for this issue

Watchers:: 5 Start watching this issue

Dates

Created:: 22/Jan/15 2:40 AM

Updated:: 06/Feb/15 3:42 AM

Resolved:: 06/Feb/15 3:42 AM

Fix Release Date:: 9/Mar/15