Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-48924

Small tgz backup (enabletgzbackups) fixes

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      1) Edit admin/settings/development.php, change default for enabletgzbackups 0 => 1
      2) Re-init & run phpunit
      3) Expect all pass, not fails in questionlib & courselib.

      Show
      1) Edit admin/settings/development.php, change default for enabletgzbackups 0 => 1 2) Re-init & run phpunit 3) Expect all pass, not fails in questionlib & courselib.
    • Affected Branches:
      MOODLE_27_STABLE, MOODLE_28_STABLE
    • Fixed Branches:
      MOODLE_27_STABLE, MOODLE_28_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      tgz_fixing

      Description

      We have been experimenting with using tgz backup ($CFG->enabletgzbackups) and even setting it as the default.

      With the default changed, a few tests fail, and it exposed a problem with get_file_packer used in some contexts on backups without the correct mimetype argument. After auditing all such usage I came up with only one other place in core which seems incorrect.

      Anyway, providing patch to get these places fixed up...

        Attachments

          Activity

            People

            Assignee:
            tlevi Tony Levi
            Reporter:
            tlevi Tony Levi
            Peer reviewer:
            Sam Marshall
            Integrator:
            Andrew Nicols
            Tester:
            Zachary Durber
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              9/Mar/15