Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-48926

Remove sleeps from spin() for behat in non-javascript mode

    XMLWordPrintable

    Details

      Description

      This is a reboot of MDL-41742.

      When using goutte driver, the DOM will never change after the initial loading and so it is pointless to wait for changes in spin().

      Against master, time to run behat with tags '~@javascript&&@mod_forum'...
      before: 3m36.416s
      after: 1m10.482s

      Unlike my previous patch, this doesn't speed up or otherwise affect the polling frequency in javascript mode, so there is not a negative performance impact there.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              tlevi Tony Levi
              Reporter:
              tlevi Tony Levi
              Peer reviewer:
              Rajesh Taneja
              Integrator:
              Dan Poltawski
              Tester:
              CiBoT
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                11/May/15