Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-48938

get_element_icon() should use pix_icon internally

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.8.2, 2.9
    • Fix Version/s: 2.9
    • Component/s: Gradebook
    • Labels:
    • Testing Instructions:
      Hide
      1. Create a course with assignments and quizzes.
      2. Make sure they appear in the Singleview user report.
      3. Change aggregation to a non-natural option and Mean of grades (with extra credits).
      4. Check back to the Singleview user report and ensure the course total icon is as expected. (compare to stable for example)
      5. Confirm the changes are reflected in Home / ▶ Courses / ▶ Miscellaneous / ▶ Coursename / ▶ Grade administration / ▶ Setup / ▶ Categories and items ▶ Edit calculation
      Show
      Create a course with assignments and quizzes. Make sure they appear in the Singleview user report. Change aggregation to a non-natural option and Mean of grades (with extra credits). Check back to the Singleview user report and ensure the course total icon is as expected. (compare to stable for example) Confirm the changes are reflected in Home / ▶ Courses / ▶ Miscellaneous / ▶ Coursename / ▶ Grade administration / ▶ Setup / ▶ Categories and items ▶ Edit calculation
    • Affected Branches:
      MOODLE_28_STABLE, MOODLE_29_STABLE
    • Fixed Branches:
      MOODLE_29_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-48938-master
    • Sprint:
      Team Beards Sprint 3

      Description

      grade_structure::get_element_icon() currently does not use core_renderer::pix_icon to generate its icons, despite using pix icons and pix_url internally.

      This issue is based upon work by Zachary Durber split out from MDL-46662; initially the plan was to add the ability to hide element icons from screen readers, but in light of Damyon Wiese's review on MDL-36009, seeing as that information cannot be dispensed with it's probably a good idea to not even bother adding that functionality.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  11/May/15