Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-48945

File type configuration: Setting description in edit form can fail

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.9
    • Fix Version/s: 2.9
    • Component/s: Administration
    • Labels:
    • Testing Instructions:
      Hide

      Note: This change includes a couple of Behat scenarios which basically do the same thing (in a bit more detail).

      1. Go to the filetypes configuration screen (under Server in the admin menu).
      2. Edit the 7z filetype.
      3. Change the dropdown to say 'custom description' and save the form without typing a custom description.
      EXPECTED: You should get a 'Required' prompt next to the empty field.
      4. Type a custom description and save the form. Note that the custom description is now shown on the table.
      5. Edit the 7z filetype again.
      6. Change the dropdown to say 'default' and save the form again.
      7. Look at the table.
      EXPECTED: The custom description has disappeared.

      Show
      Note: This change includes a couple of Behat scenarios which basically do the same thing (in a bit more detail). 1. Go to the filetypes configuration screen (under Server in the admin menu). 2. Edit the 7z filetype. 3. Change the dropdown to say 'custom description' and save the form without typing a custom description. EXPECTED: You should get a 'Required' prompt next to the empty field. 4. Type a custom description and save the form. Note that the custom description is now shown on the table. 5. Edit the 7z filetype again. 6. Change the dropdown to say 'default' and save the form again. 7. Look at the table. EXPECTED: The custom description has disappeared.
    • Affected Branches:
      MOODLE_29_STABLE
    • Fixed Branches:
      MOODLE_29_STABLE
    • Pull Master Branch:
      MDL-48945-master

      Description

      Just some minor glitches which our testing discovered...

      The edit form for a file type lets you choose between three options for the description of a file type: the default lang string, an alternative lang string, and a custom description entered in the form.

      The dropdown used to select this does not properly take effect when changing option. For example, if you have a custom description and then select 'default' in the dropdown and save the form, your custom description is not removed. (It actually works if you also delete the text of your custom description before changing the dropdown, but you shouldn't have to do that.)

      Additionally, if you select 'custom description' and then don't type one, it still lets you save the form (it'll select default). This should give a form error.

        Attachments

          Activity

            People

            • Assignee:
              quen Sam Marshall
              Reporter:
              quen Sam Marshall
              Peer reviewer:
              Zachary Durber
              Integrator:
              Dan Poltawski
              Tester:
              Rajesh Taneja
              Participants:
              Component watchers:
              Andrew Nicols, Mathew May, Michael Hawkins, Shamim Rezaie, Simey Lameze
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                11/May/15