Loading...

XML

Word

Printable

Affected Branches:
MOODLE_28_STABLE
Fixed Branches:
MOODLE_27_STABLE, MOODLE_28_STABLE
Pull from Repository:
git://github.com/danpoltawski/moodle.git
Pull Main Branch:
~~MDL-48960~~-master
Pull Main Diff URL:
https://github.com/danpoltawski/moodle/compare/4c27f52...MDL-48960-master
Testing Instructions:
Hide

Enable the device detection setting in site settings

Have a different theme for mobile devices

Use a mobile device and ensure that you can follow the 'Switch to the standard theme' link and the theme switches

BONUS: Use a clever mobile linked web inspector or user agent spoofing to verify the switchdevice link has rel="nofollow"

Go to the site calendar and Hide global events and ensure it works

Use the web inspector to ensure that the hide/show links have rel="nofollow"
Show
Enable the device detection setting in site settings Have a different theme for mobile devices Use a mobile device and ensure that you can follow the 'Switch to the standard theme' link and the theme switches BONUS: Use a clever mobile linked web inspector or user agent spoofing to verify the switchdevice link has rel="nofollow" Go to the site calendar and Hide global events and ensure it works Use the web inspector to ensure that the hide/show links have rel="nofollow"

On a few of our community sites we have logs spammed with:

Default exception handler: Incorrect sesskey submitted, form not accepted!

This comes from things like:
/theme/switchdevice.php (big one - displayed on all pages when device detection is enabled)
/calendar/set.php

We could fix that specific switchdevice link - or maybe even do something clever in htmlwriter..

Participants:: CiBoT, Dan Poltawski, David Monllaó, Frédéric Massart, Zachary Durber